-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag: add namespace rules for redirect tags #1467
tag: add namespace rules for redirect tags #1467
Conversation
@siddharthvp Is this patch OK to merge despite not agreeing with the 2 code review comments? Are your concerns sufficiently addressed? |
@siddharthvp After I fix the merge conflict, is this patch OK to merge despite not agreeing with the 2 code review comments? Are your concerns sufficiently addressed? |
@NovemLinguae Yeah go ahead. Sorry about the delayed response. Didn't realise this has been sitting for more than a year. How time flies. |
f4622cc
to
95cb152
Compare
Fixes #1459 Fix redirect category namespace detection
I found 184 {{R to/from X}} style redirect tags that are namespace-specific. This PR codes Twinkle to not display these unless it is the correct namespace.
I copy/pasted a utility function from Stack Overflow, and used a comment with a URL as attribution.
Here's a couple test cases to check: