refactor

wikimedia-gadgets · Jul 21, 2023 · 2b6f3dc · 2b6f3dc
1 parent 3489841
commit 2b6f3dc
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/modules/twinklearv.js b/modules/twinklearv.js
@@ -509,11 +509,9 @@ Twinkle.arv.callback.evaluate = function(e) {
 				}
 			}).join('; ');
 
-
 			if (form.page.value !== '') {
 				// Allow links to redirects, files, and categories
 				reason = 'On {{No redirect|:' + form.page.value + '}}';
-
 				if (form.badid.value !== '') {
 					reason += ' ({{diff|' + form.page.value + '|' + form.badid.value + '|' + form.goodid.value + '|diff}})';
 				}
@@ -523,17 +521,21 @@ Twinkle.arv.callback.evaluate = function(e) {
 			if (types) {
 				reason += ' ' + types;
 			}
+
 			if (comment !== '') {
-				var reasonNeedsPunctuation = /([.?!;:]|^)$/.test(reason);
-				reason += reasonNeedsPunctuation ? '' : '.';
+				var reasonEndsInPunctuationOrBlank = /([.?!;:]|^)$/.test(reason);
+				reason += reasonEndsInPunctuationOrBlank ? '' : '.';
 				var reasonIsBlank = reason === '';
 				reason += reasonIsBlank ? '' : ' ';
 				reason += comment;
 			}
+
 			reason = reason.trim();
-			if (!/[.?!;]$/.test(reason)) {
+			var reasonEndsInPunctuation = /[.?!;]$/.test(reason);
+			if (!reasonEndsInPunctuation) {
 				reason += '.';
 			}
+
 			reason += ' ~~~~';
 			reason = reason.replace(/\r?\n/g, '\n*:');  // indent newlines