Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two functions in the
ClonesWithImmutableArgs
library that return address as a result of thekeccak256
function:clone3
andaddressOfClone3
. Unmasked, this results in invalid value if used later in assembly code block.Imagine that the
clone3
function is used to create a clone and then its address is passed to another function that makes a call using that address as a parameter. If this assembly code, such as library, doesn’t clear the address, then this “address” will be invalid and the call will fail.I suggest masking the result of the
keccak256
function to avoid possible problems with address usage.P.S. In the commit, you can see a couple of tests that should fail when run on the production code without the suggested changes.