Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic deployment via CREATE3 #17

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

ZeframLou
Copy link
Contributor

Added cloneDeterministic() and predictDeterministic() to ClonesWithImmutableArgs to support deterministic deployment of clones.

CREATE3 was used instead of CREATE2 to avoid letting the address of the deployed contract depend on the values of the immutable args.

@wighawag
Copy link
Owner

wighawag commented Oct 8, 2023

Hey @ZeframLou that's cool
I am wondering though if the name cloneDeterministic should be reserved for the use of create2 as this is what you would expect to work where the immutable args affect the address

Not sure what name we could use for create3 ?

@ZeframLou
Copy link
Contributor Author

Hey @wighawag I have updated the naming using clone3 and addressOfClone3

@wighawag wighawag merged commit 8e345f1 into wighawag:master Oct 31, 2023
1 check passed
@wighawag
Copy link
Owner

Thanks @ZeframLou !

Merged in and publish the npm package 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants