Fixes pandas dataframe transpose display error #613
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dgetti#526' of https://github.com/SarthakNikhal/solara into FIX-solara.DataFrame-doesn't-display-row-index-names-widgetti#526
maartenbreddels
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks you @SarthakNikhal !
See my comment in the code, hope they make sense.
|
@maartenbreddels Completed the changes. |
|
Hey @SarthakNikhal! Looks like there are only two code quality errors left. Take a look at running |
…lay-row-index-names-widgetti#526
…dgetti#526' of https://github.com/SarthakNikhal/solara into FIX-solara.DataFrame-doesn't-display-row-index-names-widgetti#526
|
Done. I did not know about pre-commit. Thanks! |
|
Nice, thanks a lot @SarthakNikhal! I think the changes to |
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
86646f5
to
df2fd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #526.
Created a separate variable to store row names to display them correctly as per the index in the loop.
Also, created a new function in utils to cater for getting list of row index names just like for columns.