Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make altair work in Jupyter notebook and Jupyter Lab #288

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: make altair work in Jupyter notebook and Jupyter Lab #288

merged 2 commits into from
Sep 15, 2023

Commits on Sep 15, 2023

  1. fix: make vega and altair work in the jupyter notebook 

    Because the vega url does not end with .js the CdnHandler does not
serve the file with the correct mimetype. We do not store the mime type
on disk, so we do not know the mimetype of the file.
Currently, the mimetype is guessed based on the file extension.
By giving a more explicit path that ends in .js, we can make sure the
mimetype is set correctly.
In the end this caused the Altair component not to work.
    @maartenbreddels
    maartenbreddels committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    eb530a4 View commit details
    Browse the repository at this point in the history

  2. fix: make vega and altair work in Jupyter Lab 

    Jupyter Lab does not provide requirejs, so we need to load it ourselves
similar to what we do in other vue templates.
    @maartenbreddels
    maartenbreddels committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1ba4301 View commit details
    Browse the repository at this point in the history