feat: change plotly figure widget to allow image annotation #285
Conversation
itepifanio
changed the title
solara/components/misc.py
Outdated
|
|
||
| def update_data(): | ||
| fig_widget: FigureWidget = solara.get_widget(fig_element) | ||
| fig_widget = solara.get_widget(fig_element) |
There was a problem hiding this comment.
Why remove the typing?
There was a problem hiding this comment.
Thanks for noticing, it wasn't suppose to be removed
solara/components/misc.py
Outdated
| if hasattr(fig_widget, 'data'): | ||
| length = len(fig_widget.data) | ||
| data = list(fig_widget.data) | ||
| fig_widget.data = data[length:] |
There was a problem hiding this comment.
Why did you make this change? When is data not an attribute?
I think in any case, it's not a related change. I prefer you revert this, open a new PR, to avoid getting the PR stuck on unrelated things.
There was a problem hiding this comment.
Reverted. Some changes I made in my codebase was added here by mistake, I was testing some things on the configuration. Sorry about that.
| import solara | ||
|
|
||
| title = "Plotly Image Annotator" | ||
| text = solara.reactive('Draw on canvas') |
There was a problem hiding this comment.
I think it's cleaner to do sth like:
shapes = solara.reactive(None)
...
if "shapes" in relayout_data:
shapes.value = relayout_data["shapes"]
...
if not shapes.value:
solara.Markdown("## Draw on the canvas")
else:
solara.Markdown("## Data returned by drawing")
formatted_shapes = str(json.dumps(relayout_data["shapes"], indent=2, cls=CustomEncoder))
solara.Preformatted(formatted_shapes)
maartenbreddels
force-pushed
the
issue-249-plotly-figure-for-image-annotation
branch
from
b71aeff
to
a4db7ad
Compare
solara/website/pages/__init__.py
Outdated
| @@ -95,7 +96,7 @@ def Layout(children=[]): | |||
| sub_title="Solara helps you build powerful & scalable Jupyter and web apps <b>faster</b> and <b>easier</b>.", | |||
| button_text="Quickstart", | |||
| ) | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
why was this needed? Did you have trouble running this part? Is there something can do about it?
In any case, for this PR I think you want to revert this.
There was a problem hiding this comment.
@maartenbreddels yes, I had issues running the documentation* and ended up removing this files to run the documentation. This wasn't suppose to be deleted, it should be revered now.
*I followed the setup docs but had problems running the tests and docs. I'll try to setup again later and open some issues if needed.
| class CustomEncoder(json.JSONEncoder): | ||
| def default(self, o): | ||
| # Convert object instances to their string representation | ||
| if isinstance(o, object): | ||
| return str(o) | ||
| return super().default(o) |
There was a problem hiding this comment.
Why is this needed? Does plotly give back some objects? If so, it would be good to explain this in this piece of code.
There was a problem hiding this comment.
Does plotly give back some objects?
Yes, I added more explanation about it.
|
Did some small changes, such as making the annotation mode the default. Thank you a lot! ❤️ |
Closes #249