Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address warnings on kernel initialized dispatch #205

Conversation

lp9052
Copy link
Contributor

@lp9052 lp9052 commented Jul 11, 2023

solara\server\patch.py will throw AttributionError when app is None. This mostly show up in unit test.

maartenbreddels and others added 5 commits June 28, 2023 21:49
Instead of having a Page component, we should also just allow a user
to define a set of routes.
This is what we need for the /apps/scrolling example.
* test: enable reload tests

* fix: do not reload modules that are not under the app directory

Fixes widgetti#177
Fixes widgetti#148

* clean up code

* __file__ can be None

* call clear from the test code

* move to subdir so we do not reload the test modules
@lp9052
Copy link
Contributor Author

lp9052 commented Jul 12, 2023

@maartenbreddels could you please take a look. It's kinda annoying and misleading when we run unit test.

@lp9052
Copy link
Contributor Author

lp9052 commented Jul 19, 2023

@maartenbreddels

@maartenbreddels
Copy link
Contributor

I hit the same issue, and I generalized it a bit more, thank you for starting this!

@maartenbreddels maartenbreddels merged commit 6005f96 into widgetti:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants