enhancement: modify file bowser unit test to make it easier to understand #188
Conversation
|
in my own project I use |
|
oopsie, what happened to all these actions :) |
|
Pydantic just updated to 2.0. Shall we limit the version to <2.0 for now? |
| if not str(value).startswith(str(BASE_PATH)): | ||
| directory.value = BASE_PATH | ||
| def set_directory(path: Path) -> None: | ||
| directory.value = path if str(path).startswith(str(BASE_PATH)) else BASE_PATH |
There was a problem hiding this comment.
| directory.value = path if str(path).startswith(str(BASE_PATH)) else BASE_PATH | |
| directory.value = path if str(path).startswith(str(BASE_PATH)) else BASE_PATH |
Just to make you aware that this will always assign and will always need to do a comparison. Not that it matters because it is a test, but this might be slower in cases where compare is slow
There was a problem hiding this comment.
Hmm, I never thought about that. But it would also hard to imagine a path comparison could be too expensive. Do you have an example in mind?
There was a problem hiding this comment.
No, just wanted to make you aware that the behaviour has changed. Happy to merge this as is!
maartenbreddels
force-pushed
the
modify_file_browser_unit_test_lp9052
branch
from
5182f0d
to
9ff15ca
Compare
see #149