-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add disable keyword to select and select multiple widgets #173
feat: add disable keyword to select and select multiple widgets #173
Conversation
first PR. Want to use this to familiarize with the process. Let me know if there are specific rules for this project. I followed instruction from development page. Once this merged, I'll be able to contribute more. Happy Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
Just a few suggestions. Also in components_test.py we also have a test_select. I think we can remove that one, this one is better.
Thanks Maarten! I'll remove the test in component test. And is there any specific reason we prefer Test() over under_test() or test()? As snakecase is the preferred convention. Pep8 will report otherwise. |
urrr. I don't see components_test.py. Can you point out to me where is it? |
I see it is never added to git 🙃 |
just merged changes and please take a look |
Thank you! |
add disabled keyword to select widgets
see #144