Allow test host to be customized #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
79a6de9
to
699c7e6
Compare
and the ports configurable via the command line for pytest.
3 tasks
astrofrog
commented
Jun 29, 2023
|
|
||
| ## Changing the Hostname | ||
|
|
||
| To configure the hostname the socket is bound to when starting the test server, use the `HOST` or `SOLARA_HOST` environment variable (e.g. `SOLARA_HOST=0.0.0.0`). This hostname is also used for the jupyter server and voila. Alternatively the `--solara-host` argument can be passed on the command line for pytest. |
There was a problem hiding this comment.
Is SOLARA_HOST actually recognized currently?
There was a problem hiding this comment.
No, I've added that in this PR
There was a problem hiding this comment.
I think that should be good enough for when HOST is not specific enough, and collides with other usage. And in the case where even that is not enough, --solara-host can be used for the testing host. I think that provides enough configuration/escape hatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as #112 but when running solara though the pytest framework which means I wasn't able to set the host to 0.0.0.0. This PR adds a way to customize the host with a new environment variable. I thought HOST would be too generic so made it SOLARA_TEST_HOST. I wonder if PORT should be SOLARA_TEST_PORT too?