fix: build solara-vuetify-app with ipywidget7 and ipywidget8 support

it seems alias in a subdependency is not working, so we have to create two widget managers packages.
widgetti · Jun 23, 2023 · c482e20 · c482e20
1 parent e105b00
commit c482e20
Show file tree

Hide file tree

Showing 9 changed files with 6,470 additions and 35 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -23,7 +23,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: packages/solara-vuetify-app/dist
-          key: ${{ runner.os }}-js-bundle-${{ hashFiles('packages/solara-vuetify-app/src/**', 'packages/solara-vuetify-app/package.json', 'packages/solara-widget-manager/src/**', 'packages/solara-widget-manager/package.json') }}
+          key: ${{ runner.os }}-js-bundle-${{ hashFiles('packages/solara-vuetify-app/src/**', 'packages/solara-vuetify-app/package.json', 'packages/solara-widget-manager/src/**', 'packages/solara-widget-manager/package.json', 'packages/solara-widget-manager8/src/**', 'packages/solara-widget-manager8/package.json') }}
 
       - name: Build solara widget manager
         if: steps.cache-js-bundle.outputs.cache-hit != 'true'
@@ -32,6 +32,10 @@ jobs:
           npm install
           npm run build
           cd ../../
+          cd packages/solara-widget-manager8
+          npm install
+          npm run build
+          cd ../../
 
       - name: Build solara app package
         if: steps.cache-js-bundle.outputs.cache-hit != 'true'

diff --git a/.github/workflows/release_solara_vuetify_app.yaml b/.github/workflows/release_solara_vuetify_app.yaml
@@ -22,6 +22,10 @@ jobs:
           npm install
           npm run build
           cd ..
+          cd solara-widget-manager8
+          npm install
+          npm run build
+          cd ..
           cd solara-vuetify-app
           npm install
           npm run build

diff --git a/packages/solara-vuetify-app/package-lock.json b/packages/solara-vuetify-app/package-lock.json
diff --git a/packages/solara-vuetify-app/webpack.config.js b/packages/solara-vuetify-app/webpack.config.js
@@ -71,9 +71,7 @@ module.exports = [
         },
         resolve: {
             alias: {
-                "@jupyter-widgets/base": "@jupyter-widgets/base8",
-                "@jupyter-widgets/controls": "@jupyter-widgets/controls8",
-                "@jupyter-widgets/jupyterlab-manager": "@jupyter-widgets/jupyterlab-manager8",
+                "@widgetti/solara-widget-manager": "@widgetti/solara-widget-manager8",
             }
         },
         mode: 'production',
@@ -93,9 +91,7 @@ module.exports = [
         },
         resolve: {
             alias: {
-                "@jupyter-widgets/base": "@jupyter-widgets/base8",
-                "@jupyter-widgets/controls": "@jupyter-widgets/controls8",
-                "@jupyter-widgets/jupyterlab-manager": "@jupyter-widgets/jupyterlab-manager8",
+                "@widgetti/solara-widget-manager": "@widgetti/solara-widget-manager8",
             }
         },
         mode: 'development',