fix: incorrectly turned path and dark into one object

widgetti · Feb 20, 2024 · a4f5556 · a4f5556
1 parent 5909b8b
commit a4f5556
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/packages/solara-widget-manager/src/manager.ts b/packages/solara-widget-manager/src/manager.ts
@@ -149,7 +149,8 @@ export class WidgetManager extends JupyterLabManager {
     await this._loadFromKernel();
   }
 
-  async run(appName: string, path: string) {
+  async run(appName: string, args: any) {
+    let { path } = args;
     // used for routing
     // should be similar to what we do in navigator.vue
     if (typeof path === 'undefined') {
@@ -173,7 +174,7 @@ export class WidgetManager extends JupyterLabManager {
         }
       };
     });
-    this.controlComm.send({ method: 'run', path, appName: appName || null });
+    this.controlComm.send({ method: 'run', args: { ...args, appName: appName || null } });
     const widget_id = await widget_id_promise;
     return widget_id;
   }

diff --git a/solara/server/app.py b/solara/server/app.py
@@ -350,11 +350,12 @@ def on_msg(msg):
         data = msg["content"]["data"]
         method = data["method"]
         if method == "run":
-            path = data.get("path", "")
-            app_name = data.get("appName") or "__default__"
+            args = data["args"]
+            path = args.get("path", "")
+            app_name = args.get("appName") or "__default__"
             app = apps[app_name]
             context = kernel_context.get_current_context()
-            dark = data.get("darkMode", False)
+            dark = args.get("dark", False)
             import ipyvuetify
 
             from solara.lab import theme

diff --git a/solara/server/static/main-vuetify.js b/solara/server/static/main-vuetify.js
@@ -227,7 +227,7 @@ async function solaraInit(mountId, appName) {
     if (kernelId && widgetModelId) {
         await widgetManager.fetchAll();
     } else {
-        widgetModelId = await widgetManager.run(appName, {path, darkMode: inDarkMode()});
+        widgetModelId = await widgetManager.run(appName, {path, dark: inDarkMode()});
     }
     await solaraMount(widgetManager, mountId || 'content', widgetModelId);
     skipReconnectedCheck = false;