Skip to content

Commit

Permalink
implement suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
iisakkirotko committed Mar 18, 2024
1 parent 60f7a87 commit 95691b5
Show file tree
Hide file tree
Showing 9 changed files with 268 additions and 338 deletions.
41 changes: 0 additions & 41 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,44 +5,3 @@ updates:
directory: "/"
schedule:
interval: "weekly"
day-of-week: "friday"
time: "5:00"
timezone: "Europe/Amsterdam"

# Maintain dependencies for frontend packages
# These should already scan solara-widget-manager, since
# Those are dependencies
- package-ecosystem: "npm"
directory: "/packages/solara-vuetify-app"
schedule:
interval: "weekly"
day-of-week: "friday"
time: "5:00"
timezone: "Europe/Amsterdam"
ignore:
# Ignore Vuetify, since we're locked to a specific version
- dependency-name: "vuetify"
versions: ["2.x"]
labels:
- "javascript dependencies"

- package-ecosystem: "npm"
directory: "/packages/solara-vuetify3-app"
schedule:
interval: "weekly"
day-of-week: "friday"
time: "5:00"
timezone: "Europe/Amsterdam"
labels:
- "javascript dependencies"

# Maintain dependencies for main python package
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"
day-of-week: "friday"
time: "5:00"
timezone: "Europe/Amsterdam"
labels:
- "python dependencies"
71 changes: 0 additions & 71 deletions .github/workflows/build.yml

This file was deleted.

33 changes: 0 additions & 33 deletions .github/workflows/codequality.yaml

This file was deleted.

65 changes: 0 additions & 65 deletions .github/workflows/installation.yml

This file was deleted.

54 changes: 0 additions & 54 deletions .github/workflows/javascript.yaml

This file was deleted.

62 changes: 0 additions & 62 deletions .github/workflows/release.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions .github/workflows/release_solara_vuetify_app-v3.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unlike the Python package release, the javascript release doesn't depend on tests passing
# If a broken version is release without a Python release it isn't used, since the version
# is fixed in the Python package
name: Release solara-vuetify3-app package

on:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release_solara_vuetify_app.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unlike the Python package release, the javascript release doesn't depend on tests passing
# If a broken version is release without a Python release it isn't used, since the version
# is fixed in the Python package
name: Release solara-vuetify-app package

on:
Expand Down
Loading

0 comments on commit 95691b5

Please sign in to comment.