fix: Final review changes (?) - remove defaults and make empty str ar…

…ray not None-array
widgetti · Sep 9, 2023 · 87f57ef · 87f57ef
1 parent 65902f3
commit 87f57ef
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/solara/components/slider.py b/solara/components/slider.py
@@ -23,7 +23,7 @@ def SliderInt(
     max: int = 10,
     step: int = 1,
     on_value: Optional[Callable[[int], None]] = None,
-    thumb_label: Union[bool, Literal["always"]] = "always",
+    thumb_label: Union[bool, Literal["always"]] = True,
     tick_labels: Union[List[str], Literal["end_points"], bool] = False,
     disabled: bool = False,
 ):
@@ -68,7 +68,7 @@ def set_value_cast(value):
 
     if tick_labels == "end_points":
         num_repeats = int(math.ceil((max - min) / step)) - 1
-        tick_labels = [str(min), *([None] * num_repeats), str(max)]
+        tick_labels = [str(min), *([""] * num_repeats), str(max)]
 
     return rv.Slider(
         v_model=reactive_value.value,
@@ -93,7 +93,7 @@ def SliderRangeInt(
     max: int = 10,
     step: int = 1,
     on_value: Callable[[Tuple[int, int]], None] = None,
-    thumb_label: Union[bool, Literal["always"]] = "always",
+    thumb_label: Union[bool, Literal["always"]] = True,
     tick_labels: Union[List[str], Literal["end_points"], bool] = False,
     disabled: bool = False,
 ) -> reacton.core.ValueElement[ipyvuetify.RangeSlider, Tuple[int, int]]:
@@ -137,7 +137,7 @@ def set_value_cast(value):
 
     if tick_labels == "end_points":
         num_repeats = int(math.ceil((max - min) / step)) - 1
-        tick_labels = [str(min), *([None] * num_repeats), str(max)]
+        tick_labels = [str(min), *([""] * num_repeats), str(max)]
 
     return cast(
         reacton.core.ValueElement[ipyvuetify.RangeSlider, Tuple[int, int]],
@@ -165,7 +165,7 @@ def SliderFloat(
     max: float = 10.0,
     step: float = 0.1,
     on_value: Callable[[float], None] = None,
-    thumb_label: Union[bool, Literal["always"]] = "always",
+    thumb_label: Union[bool, Literal["always"]] = True,
     tick_labels: Union[List[str], Literal["end_points"], bool] = False,
     disabled: bool = False,
 ):
@@ -208,7 +208,7 @@ def set_value_cast(value):
 
     if tick_labels == "end_points":
         num_repeats = int(math.ceil((max - min) / step)) - 1
-        tick_labels = [str(min), *([None] * num_repeats), str(max)]
+        tick_labels = [str(min), *([""] * num_repeats), str(max)]
 
     return rv.Slider(
         v_model=reactive_value.value,
@@ -233,7 +233,7 @@ def SliderRangeFloat(
     max: float = 10.0,
     step: float = 0.1,
     on_value: Callable[[Tuple[float, float]], None] = None,
-    thumb_label: Union[bool, Literal["always"]] = "always",
+    thumb_label: Union[bool, Literal["always"]] = True,
     tick_labels: Union[List[str], Literal["end_points"], bool] = False,
     disabled: bool = False,
 ) -> reacton.core.ValueElement[ipyvuetify.RangeSlider, Tuple[float, float]]:
@@ -277,7 +277,7 @@ def set_value_cast(value):
 
     if tick_labels == "end_points":
         num_repeats = int(math.ceil((max - min) / step)) - 1
-        tick_labels = [str(min), *([None] * num_repeats), str(max)]
+        tick_labels = [str(min), *([""] * num_repeats), str(max)]
 
     return cast(
         reacton.core.ValueElement[ipyvuetify.RangeSlider, Tuple[float, float]],