Skip to content

Commit

Permalink
Further code review
Browse files Browse the repository at this point in the history
Co-authored-by: Maarten Breddels <[email protected]>
  • Loading branch information
iisakkirotko and maartenbreddels committed Sep 11, 2023
1 parent d555896 commit 2ebca5b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions solara/components/togglebuttons.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ def Page():
class_ = _combine_classes(classes)
style_flat = solara.util._flatten_style(style)
# TODO: make type safe
# typing is ignored below due to an issue with the typing of use_reactive; Typechecker expects a different type than is given. If expected type is
# given instead, a similar error shows up in typing of argument.
# typing is ignored below due to an issue with the typing; The combination of value being T and on_value being of type Callback[[Optional[T]], None] is not allowed to be passed to use_reactive. We also do not allow this by using our overloads, but this information seems lost at this point by the typechecker```
reactive_value = solara.use_reactive(value, on_value) # type: ignore
children = [solara.Button(label=str(value)) for value in values] + children
values = values + [_get_button_value(button) for button in children] # type: ignore
Expand Down

0 comments on commit 2ebca5b

Please sign in to comment.