fix: normalize path for windows to avoid case mismatch

widgetti · Jul 11, 2024 · 1a28643 · 1a28643
1 parent cf52a3d
commit 1a28643
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/solara/server/cdn_helper.py b/solara/server/cdn_helper.py
@@ -29,8 +29,14 @@ def get_from_cache(base_cache_dir: pathlib.Path, path):
     # which is a security risk.
     # We use os.path.normpath() because we do not want to follow symlinks
     # in editable installs, since some packages are symlinked
-    if not os.path.normpath(cache_path).startswith(str(base_cache_dir.resolve())):
-        logger.warning("Trying to read from outside of cache directory: %s is not a subdir of %s", cache_path, base_cache_dir)
+    if not os.path.normpath(cache_path).startswith(os.path.normpath(base_cache_dir)):
+        logger.warning(
+            "Trying to read from outside of cache directory: %s is not a subdir of %s (%s - %s)",
+            cache_path,
+            base_cache_dir,
+            os.path.normpath(cache_path),
+            os.path.normpath(base_cache_dir),
+        )
         raise PermissionError("Trying to read from outside of cache directory")
 
     try: