fix: close playwright properly when building ssg #208

Workflow file for this run

	name: Test

	on:
	push:
	branches:
	- master
	tags:
	- v*
	pull_request:
	workflow_dispatch:
	schedule:
	- cron: '0 6 * * *' # at 06:00 UTC every day

	concurrency:
	group: ${{ github.workflow }}-${{ github.ref }}
	cancel-in-progress: ${{ !(github.ref == 'refs/heads/master') }}

	env:
	SOLARA_TELEMETRY_SERVER_USER_ID: "install-test"
	SOLARA_TELEMETRY_MIXPANEL_TOKEN: adbf863d17cba80db608788e7fce9843

	defaults:
	run:
	shell: bash {0}

	jobs:
	build:
	runs-on: ubuntu-latest

	steps:
	- uses: actions/checkout@v4

	- name: Set up Python ${{ matrix.python-version }}
	uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python-version }}

	- uses: actions/setup-node@v4
	with:
	node-version: 20

	- name: Cache JS bundle
	id: cache-js-bundle-v2
	uses: actions/cache@v4
	with:
	path: \|
	packages/solara-vuetify-app/dist
	packages/solara-vuetify3-app/dist
	key: ${{ runner.os }}-js-bundle-${{ hashFiles('packages/solara-vuetify-app/', 'packages/solara-vuetify3-app/', 'packages/solara-widget-manager/', 'packages/solara-widget-manager8/src/') }}

	- name: Build solara widget manager
	if: steps.cache-js-bundle-v2.outputs.cache-hit != 'true'
	run: \|
	cd packages/solara-widget-manager
	npm install
	npm run build
	cd ../../
	cd packages/solara-widget-manager8
	npm install
	npm run build
	cd ../../

	- name: Build solara app package
	if: steps.cache-js-bundle-v2.outputs.cache-hit != 'true'
	run: \|
	cd packages/solara-vuetify-app
	npm install
	npm run build
	cd ../../
	cd packages/solara-vuetify3-app
	npm install
	npm run build

	- name: Install build tools
	run: pip install hatch

	- name: Build solara
	run: hatch build

	- name: Build solara-enterprise
	run: (cd packages/solara-enterprise; hatch build)

	- name: Upload Test artifacts
	if: always()
	uses: actions/upload-artifact@v4
	with:
	name: solara-builds-${{ github.run_number }}
	path: \|
	dist
	packages/solara-enterprise/dist
	packages/solara-vuetify-app/dist
	packages/solara-vuetify3-app/dist

	code-quality:
	runs-on: ubuntu-latest
	strategy:
	fail-fast: false
	matrix:
	python-version: [3.8, "3.9"]

	steps:
	- uses: actions/checkout@v4

	- name: Set up Python ${{ matrix.python-version }}
	uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python-version }}

	- name: Install dependencies
	run: \|
	pip install ".[dev]" mypy==1.6.0 black==22.12.0 codespell==2.2.4 "click<8.1.4" "traitlets<5.10.0" "matplotlib<3.8.0"

	- name: Run codespell
	run: codespell

	- name: Run black
	run: black solara

	- name: Run flake8
	uses: suo/flake8-github-action@releases/v1
	with:
	checkName: 'code-quality'

	- name: mypy
	run: mypy --install-types --non-interactive solara

	test-install:
	needs: [build]
	runs-on: ${{ matrix.os }}-${{matrix.os == 'ubuntu' && '20.04' \|\| 'latest' }}
	strategy:
	fail-fast: false
	matrix:
	os: [ubuntu, macos, windows]
	python: ["3.6", "3.10"]
	exclude:
	- os: windows
	python: 3.6

	steps:
	- name: Set up Python
	uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python }}

	- uses: actions/checkout@v4

	- uses: actions/download-artifact@v4
	with:
	name: solara-builds-${{ github.run_number }}

	- name: Debug
	run: ls -R dist

	- name: Install
	run: pip install dist/*.whl

	- name: Test import
	run: python -c "import solara"

	- name: Run solara create
	run: solara create button test.py

	- name: Run solara server
	run: solara run test.py&

	- name: Wait for Solara server to get online
	uses: ifaxity/wait-on-action@v1
	with:
	resource: http-get://localhost:8765/
	timeout: 20000

	- name: Install
	run: pip install packages/solara-enterprise/dist/*.whl

	- name: Test import
	run: python -c "import solara_enterprise"

	integration-test:
	needs: [build]
	timeout-minutes: 15
	runs-on: ubuntu-latest
	strategy:
	fail-fast: false
	matrix:
	# just ubuntu and windows give enough confidence
	# osx should work fine (and we test that locally often)
	os: [ubuntu, windows]
	# just 1 version, it's heavy
	python-version: [3.8]
	ipywidgets: ["7.7", "8.0"]
	include:
	- ipywidgets: "7.7"
	voila: "0.3.0"
	- ipywidgets: "8.0"
	voila: "0.4.0"
	env:
	LOCK_FILE_LOCATION: .ci-package-locks/integration/os${{ matrix.os }}-python${{ matrix.python-version }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}.txt

	steps:
	- uses: actions/checkout@v4

	- name: Set up Python ${{ matrix.python-version }}
	uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python-version }}
	cache: "pip"

	- uses: actions/download-artifact@v4
	with:
	name: solara-builds-${{ github.run_number }}

	- name: Link solara app package
	run: \|
	cd packages/solara-vuetify-app
	npm run devlink

	- name: Prepare
	id: prepare
	run: \|
	mkdir test-results
	if [ -f ${{ env.LOCK_FILE_LOCATION }} ]; then
	echo "::set-output name=locks_exist::true"
	else
	echo "::set-output name=locks_exist::false"
	fi

	- name: Install without locking versions
	if: github.event_name == 'schedule' \|\| steps.prepare.outputs.locks_exist == 'false'
	id: install_no_lock
	run: \|
	mkdir -p .ci-package-locks/integration
	find dist/ -name '*.whl' -exec pip install {}\[dev,documentation,flask,pytest,server\] \;
	find packages/solara-enterprise/dist/ -name '*.whl' -exec pip install {}\[ssg,auth\] \;
	pip install "voila~=${{ matrix.voila }}" "jupyterlab<4" "pydantic<2" "playwright==1.41.2" "ipywidgets~=${{ matrix.ipywidgets }}"
	pip freeze --exclude solara --exclude solara-enterprise > ${{ env.LOCK_FILE_LOCATION }}
	git diff --quiet \|\| echo "::set-output name=has_diff::true"

	- name: Install
	if: github.event_name != 'schedule' && steps.prepare.outputs.locks_exist == 'true'
	run: \|
	pip install -r ${{ env.LOCK_FILE_LOCATION }}
	find dist/ -name '*.whl' -exec pip install {}\[dev,documentation,flask,pytest,server\] \;
	find packages/solara-enterprise/dist/ -name '*.whl' -exec pip install {}\[ssg,auth\] \;

	- name: Install playwright
	run: playwright install

	- name: test
	if: github.event_name != 'schedule' \|\| steps.install_no_lock.outputs.has_diff == true
	env:
	AUTH0_USERNAME: [email protected]
	AUTH0_PASSWORD: ${{ secrets.AUTH0_PASSWORD }}
	FIEF_USERNAME: [email protected]
	FIEF_PASSWORD: ${{ secrets.FIEF_PASSWORD }}
	# TODO: we used to also run the (cheap) unittests, to get better coverage report, but that gives errors
	# it seems on CI that the default playwright timeout is not (always?) respected, also, if the --timeout argument
	# is shorter than the timeout of playwright, we get no good error message, summary: always keep above 30!
	run: pytest tests/integration --timeout=360 --video=retain-on-failure --output=test-results -vv -s --log-cli-level=warning

	- name: Upload Test artifacts
	if: github.event_name != 'schedule' \|\| steps.install_no_lock.outputs.has_diff == true
	uses: actions/upload-artifact@v4
	with:
	name: test-results-integration-os${{ matrix.os }}-python${{ matrix.python-version }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
	path: test-results

	- name: Upload CI package locks
	if: steps.install_no_lock.outputs.has_diff == true \|\| steps.prepare.outputs.locks_exist == 'false'
	uses: actions/upload-artifact@v4
	with:
	name: ci-package-locks-integration-os${{ matrix.os }}-python${{ matrix.python-version }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
	path: ./**/${{ env.LOCK_FILE_LOCATION }}

	integration-test-vue3:
	needs: [build]
	timeout-minutes: 15
	runs-on: ubuntu-latest
	strategy:
	fail-fast: false
	matrix:
	# just ubuntu and windows give enough confidence
	# osx should work fine (and we test that locally often)
	os: [ubuntu]
	# just 1 version, it's heavy
	python-version: [3.8]
	ipywidgets: ["8.0"]
	include:
	- ipywidgets: "8.0"
	voila: "0.4.0"
	env:
	LOCK_FILE_LOCATION: .ci-package-locks/integration-vue3/os${{ matrix.os }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}.txt

	steps:
	- uses: actions/checkout@v4

	- name: Set up Python ${{ matrix.python-version }}
	uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python-version }}
	cache: "pip"

	- uses: actions/download-artifact@v4
	with:
	name: solara-builds-${{ github.run_number }}

	- name: Link solara app package
	run: \|
	(cd packages/solara-vuetify-app; npm run devlink)
	(cd packages/solara-vuetify3-app; npm run devlink)

	- name: Prepare
	id: prepare
	run: \|
	mkdir test-results
	if [ -f ${{ env.LOCK_FILE_LOCATION }} ]; then
	echo "::set-output name=locks_exist::true"
	else
	echo "::set-output name=locks_exist::false"
	fi

	- name: Install without locking versions
	id: install_no_lock
	if: github.event_name == 'schedule' \|\| steps.prepare.outputs.locks_exist == 'false'
	run: \|
	mkdir -p .ci-package-locks/integration-vue3
	find dist/ -name '*.whl' -exec pip install {}\[dev,documentation,flask,pytest,server\] \;
	find packages/solara-enterprise/dist/ -name '*.whl' -exec pip install {}\[ssg,auth\] \;
	pip install "jupyterlab<4" "voila~=${{ matrix.voila }}" "playwright==1.41.2" "pydantic<2" "ipywidgets~=${{ matrix.ipywidgets }}"
	pip install jupyter_core jupyter-packaging
	pip install --pre ipyvue ipyvuetify
	pip freeze --exclude solara --exclude solara-enterprise > ${{ env.LOCK_FILE_LOCATION }}
	git diff --quiet \|\| echo "::set-output name=has_diff::true"

	- name: Install
	if: github.event_name != 'schedule' && steps.prepare.outputs.locks_exist == 'true'
	run: \|
	pip install -r ${{ env.LOCK_FILE_LOCATION }}
	find dist/ -name '*.whl' -exec pip install {}\[dev,documentation,flask,pytest,server\] \;
	find packages/solara-enterprise/dist/ -name '*.whl' -exec pip install {}\[ssg,auth\] \;

	- name: Install playwright
	run: playwright install

	- name: test
	if: github.event_name != 'schedule' \|\| steps.install_no_lock.outputs.has_diff == true
	env:
	AUTH0_USERNAME: [email protected]
	AUTH0_PASSWORD: ${{ secrets.AUTH0_PASSWORD }}
	FIEF_USERNAME: [email protected]
	FIEF_PASSWORD: ${{ secrets.FIEF_PASSWORD }}
	# TODO: we used to also run the (cheap) unittests, to get better coverage report, but that gives errors
	# it seems on CI that the default playwright timeout is not (always?) respected, also, if the --timeout argument
	# is shorter than the timeout of playwright, we get no good error message, summary: always keep above 30!
	run: pytest tests/integration/widget_test.py --timeout=360 --video=retain-on-failure --output=test-results -vv -s --log-cli-level=warning

	- name: Upload Test artifacts
	if: github.event_name != 'schedule' \|\| steps.install_no_lock.outputs.has_diff == true
	uses: actions/upload-artifact@v4
	with:
	name: test-results-integration-vue3-os${{ matrix.os }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
	path: test-results

	- name: Upload CI package locks
	if: steps.install_no_lock.outputs.has_diff == true \|\| steps.prepare.outputs.locks_exist == 'false'
	uses: actions/upload-artifact@v4
	with:
	name: ci-package-locks-integration-vue3-os${{ matrix.os }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
	path: ./**/${{ env.LOCK_FILE_LOCATION }}

	unit-test:
	needs: [build]
	runs-on: ${{ matrix.os }}-${{matrix.os == 'ubuntu' && '20.04' \|\| 'latest' }}
	strategy:
	fail-fast: false
	matrix:
	os: [ubuntu, macos, windows]
	python: [3.6, 3.9]
	ipywidgets: ["7.7", "8.0"]
	exclude:
	- os: windows
	python: 3.6
	- os: ubuntu
	python: 3.6
	ipywidgets: "8.0"
	- os: macos
	python: 3.6
	ipywidgets: "8.0"
	env:
	LOCK_FILE_LOCATION: .ci-package-locks/unit/os${{ matrix.os }}-python${{ matrix.python }}-ipywidgets${{ matrix.ipywidgets }}.txt

	steps:
	- uses: actions/checkout@v4

	- name: Set up Python
	uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python }}
	cache: "pip"

	- uses: actions/download-artifact@v4
	with:
	name: solara-builds-${{ github.run_number }}

	- name: Prepare
	id: prepare
	run: \|
	if [ -f ${{ env.LOCK_FILE_LOCATION }} ]; then
	echo "::set-output name=locks_exist::true"
	else
	echo "::set-output name=locks_exist::false"
	fi

	- name: Install without locking versions
	id: install_no_lock
	if: github.event_name == 'schedule' \|\| steps.prepare.outputs.locks_exist == 'false'
	run: \|
	mkdir -p .ci-package-locks/unit
	find dist/ -name '*.whl' -exec pip install {}\[dev,extra\] \;
	find packages/solara-enterprise/dist/ -name '*.whl' -exec pip install {}\[ssg,auth\] \;
	pip install "jupyterlab<4" diskcache redis "ipywidgets~=${{ matrix.ipywidgets }}"
	pip freeze --exclude solara --exclude solara-enterprise > ${{ env.LOCK_FILE_LOCATION }}
	git diff --quiet \|\| echo "::set-output name=has_diff::true"

	- name: Install
	if: github.event_name != 'schedule' && steps.prepare.outputs.locks_exist == 'true'
	run: \|
	pip install -r ${{ env.LOCK_FILE_LOCATION }}
	find dist/ -name '*.whl' -exec pip install {}\[dev,extra\] \;
	find packages/solara-enterprise/dist/ -name '*.whl' -exec pip install {}\[ssg,auth\] \;

	- name: Start Redis
	if: ( github.event_name != 'schedule' \|\| steps.install_no_lock.outputs.has_diff == true ) && matrix.os != 'windows'
	uses: shogo82148/actions-setup-redis@v1

	- name: test
	if: github.event_name != 'schedule' \|\| steps.install_no_lock.outputs.has_diff == true
	run: pytest tests/unit --doctest-modules --timeout=60

	- name: Upload CI package locks
	if: steps.install_no_lock.outputs.has_diff == true \|\| steps.prepare.outputs.locks_exist == 'false'
	uses: actions/upload-artifact@v4
	with:
	name: ci-package-locks-unit-os${{ matrix.os }}-python${{ matrix.python }}-ipywidgets${{ matrix.ipywidgets }}
	path: ./**/${{ env.LOCK_FILE_LOCATION }}

	update-ci-package-locks:
	needs: [code-quality, integration-test, integration-test-vue3, unit-test]
	runs-on: ubuntu-latest

	steps:
	- uses: actions/checkout@v4
	with:
	fetch-depth: 0
	ref: ${{ github.head_ref \|\| github.ref }}
	repository: ${{ github.event.pull_request.head.repo.full_name \|\| github.event.repository.full_name }}

	- name: Prepare
	id: prepare
	run: \|
	if [ -d .ci-package-locks ]; then
	echo "::set-output name=locks_exist::true"
	else
	echo "::set-output name=locks_exist::false"
	fi

	- uses: actions/download-artifact@v4
	if: github.event_name == 'schedule' \|\| steps.prepare.outputs.locks_exist == 'false'
	with:
	pattern: ci-package-locks-*
	merge-multiple: true

	- name: Update CI package locks
	if: github.event_name == 'schedule' \|\| steps.prepare.outputs.locks_exist == 'false'
	run: \|
	git config user.name 'github-actions[bot]'
	git config user.email 'github-actions[bot]@users.noreply.github.com'

	git add .ci-package-locks
	git commit -m "Update CI package locks"
	git push

	release:
	needs: [build, code-quality, test-install, integration-test, integration-test-vue3, unit-test]
	if: startsWith(github.event.ref, 'refs/tags/v')
	runs-on: ubuntu-latest

	steps:
	- uses: actions/checkout@v4

	- name: Set up Python 3.7
	uses: actions/setup-python@v5
	with:
	python-version: 3.7

	- uses: actions/download-artifact@v4
	with:
	name: solara-builds-${{ github.run_number }}

	- name: Install build tools
	run: pip install hatch

	- name: Install solara
	run: pip install dist/*.whl

	- name: Test import
	run: python -c "import solara; import solara.server.starlette"

	- name: Install solara-enterprise
	run: pip install packages/solara-enterprise/dist/*.whl

	- name: Test import solara-enterprise
	run: python -c "import solara_enterprise"

	- uses: actions/setup-node@v4
	with:
	node-version: 20

	- name: Build assets
	run: (cd packages/assets; hatch build)

	- name: Publish solara-enterprise to PyPI
	env:
	HATCH_INDEX_USER: __token__
	HATCH_INDEX_AUTH: ${{ secrets.pypi_enterprise }}
	run: \|
	cd packages/solara-enterprise
	openssl sha256 dist/*
	hatch publish
	openssl sha256 dist/*

	- name: Publish solara to PyPI
	env:
	HATCH_INDEX_USER: __token__
	HATCH_INDEX_AUTH: ${{ secrets.pypi_password }}
	run: \|
	openssl sha256 dist/*
	hatch publish
	openssl sha256 dist/*

	- name: Publish solara-assets to PyPI
	env:
	HATCH_INDEX_USER: __token__
	HATCH_INDEX_AUTH: ${{ secrets.pypi_assets }}
	run: (cd packages/assets; openssl sha256 dist/; hatch publish; openssl sha256 dist/)

	- name: remove assets
	run: rm -rf packages/assets/dist

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: close playwright properly when building ssg #208

Workflow file

fix: close playwright properly when building ssg #208

Jobs

Run details

Workflow file for this run