Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error #43

Closed
wants to merge 0 commits into from
Closed

Fix type error #43

wants to merge 0 commits into from

Conversation

vthemelis
Copy link
Contributor

This is to pacify pyre or any other types checker that someone might be using in conjunction to this project.

@mariobuikhuizen
Copy link
Contributor

I think we want to use the same linting setup as our other projects (e.g., https://github.com/widgetti/solara) here. We should check it with pre-commit and in CI. However, we still have an issue with running it in CI (see widgetti/solara#225). Otherwise, we'll have no way of knowing whether this fixes the lint error. Additionally, we'll keep getting new code with potential lint errors.

@vthemelis
Copy link
Contributor Author

Fair. I normally use pyre for type checking. I think it's slightly nicer to work with in codebase with sparse initial type annotations and it's also much faster. I see that in solar you're using mypy. Would you like me to stick with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants