a few client fixes

whitslack · Dec 20, 2023 · eca63f1 · eca63f1
1 parent 5561fd3
commit eca63f1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/Source/WebKitLegacy/qt/WebCoreSupport/ChromeClientQt.h b/Source/WebKitLegacy/qt/WebCoreSupport/ChromeClientQt.h
@@ -114,6 +114,9 @@ class ChromeClientQt final : public ChromeClient {
 
     void setStatusbarText(const String&) final;
 
+    void rootFrameAdded(const LocalFrame&) final { }
+    void rootFrameRemoved(const LocalFrame&) final { }
+
     KeyboardUIMode keyboardUIMode() final;
 
     void invalidateRootView(const IntRect&) final;
@@ -207,11 +210,11 @@ class ChromeClientQt final : public ChromeClient {
 
     void requestCookieConsent(CompletionHandler<void(WebCore::CookieConsentDecisionResult)>&&) final;
 
-    IntPoint accessibilityScreenToRootView(const IntPoint&) const;
-    IntRect rootViewToAccessibilityScreen(const IntRect&) const;
-    void didFinishLoadingImageForElement(HTMLImageElement&);
-    void intrinsicContentsSizeChanged(const IntSize&) const;
-    RefPtr<Icon> createIconForFiles(const Vector<WTF::String>&);
+    IntPoint accessibilityScreenToRootView(const IntPoint&) const final;
+    IntRect rootViewToAccessibilityScreen(const IntRect&) const final;
+    void didFinishLoadingImageForElement(HTMLImageElement&) final;
+    void intrinsicContentsSizeChanged(const IntSize&) const final;
+    RefPtr<Icon> createIconForFiles(const Vector<WTF::String>&) override;
 
     QWebFullScreenVideoHandler* createFullScreenVideoHandler();
 

diff --git a/Source/WebKitLegacy/qt/WebCoreSupport/FrameLoaderClientQt.h b/Source/WebKitLegacy/qt/WebCoreSupport/FrameLoaderClientQt.h
@@ -160,6 +160,8 @@ class FrameLoaderClientQt final : public QObject, public LocalFrameLoaderClient
     ResourceError httpNavigationWithHTTPSOnlyError(const ResourceRequest&) const override;
     ResourceError pluginWillHandleLoadError(const ResourceResponse&) const override;
 
+    void loadStorageAccessQuirksIfNeeded() final { }
+
     bool shouldFallBack(const ResourceError&) const override;
 
     bool canHandleRequest(const WebCore::ResourceRequest&) const override;