Skip to content

Commit

Permalink
add corner case for dispath suspension proposal
Browse files Browse the repository at this point in the history
Signed-off-by: changzhen <[email protected]>
  • Loading branch information
XiShanYongYe-Chang committed Aug 16, 2024
1 parent 235ec91 commit b99fb63
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions docs/proposals/dispatch-suspension/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ type WorkSpec struct {
}
```

A new ConditionType called `SuspendDispatching` is introduced to describe the distribution suspension status of the Work resource. Meanwhile, the system will also report events to record the suspension of resource distribution.
A new ConditionType called `Dispatching` is introduced to describe the distribution suspension status of the Work resource. Meanwhile, the system will also report events to record the suspension of resource distribution.

### User usage example

Expand Down Expand Up @@ -195,7 +195,7 @@ spec:
status:
conditions:
- lastTransitionTime: "2024-07-01T08:33:28Z"
message: resource distribution is in a pause state.
message: Work dispatching is in a suspended state.
reason: SuspendDispatching
status: "True"
type: Dispatching
Expand Down Expand Up @@ -256,6 +256,12 @@ If, after synchronizing the new version of the resource to the member1 cluster,

Q&A: How to remove the annotation `propagation.karmada.io/instruction` from Work? It can be carried by the `Dispatching` field in the Work.

### Corner Case Consideration

1. Resource dispatching suspension does not block resource deletion.

When a user specifies through PropagationPolicy that a resource is in a dispatching suspension, and then performs a deletion operation with the intention of removing the resource, the resource will be deleted normally without blocking the deletion, thus preventing leftover resources in the member clusters.

### Test Plan

#### UT
Expand Down

0 comments on commit b99fb63

Please sign in to comment.