avoid updating directly cached resource template

for clean up policy Signed-off-by: whitewindmills <[email protected]>
whitewindmills · Aug 2, 2023 · 472d5c5 · 472d5c5
1 parent d916d87
commit 472d5c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/detector/detector.go b/pkg/detector/detector.go
@@ -1124,6 +1124,7 @@ func (d *ResourceDetector) CleanupLabels(objRef workv1alpha2.ObjectReference, la
 		return err
 	}
 
+	workload = workload.DeepCopy()
 	workloadLabels := workload.GetLabels()
 	for _, l := range labels {
 		delete(workloadLabels, l)

diff --git a/pkg/detector/policy.go b/pkg/detector/policy.go
@@ -272,9 +272,13 @@ func (d *ResourceDetector) removeResourceLabelsIfNotMatch(objectReference workv1
 		return false, nil
 	}
 
+	object = object.DeepCopy()
+	objLabels := object.GetLabels()
 	for _, labelKey := range labelKeys {
-		util.RemoveLabel(object, labelKey)
+		delete(objLabels, labelKey)
 	}
+	object.SetLabels(objLabels)
+
 	err = d.Client.Update(context.TODO(), object)
 	if err != nil {
 		return false, err