Fixed price instanciation with minor value of 0

whitecube · Jul 20, 2023 · b617314 · b617314
1 parent 55b1dca
commit b617314
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Models/Price.php b/src/Models/Price.php
@@ -43,7 +43,9 @@ public function __construct(
 
     public function fill(array $attributes)
     {
-        if ($minor = $attributes['minor'] ?? null) {
+        $minor = $attributes['minor'] ?? null;
+
+        if (! is_null($minor)) {
             $attributes['amount'] = $minor;
         } else if (($amount = $attributes['amount'] ?? null) && ($currency = $attributes['currency'] ?? null)) {
             $attributes['amount'] = Money::of($amount, $currency)->getMinorAmount()->toInt();

diff --git a/tests/Feature/InstanciationTest.php b/tests/Feature/InstanciationTest.php
@@ -32,6 +32,22 @@
     $this->assertSame('EUR', $price->currency);
 });
 
+test('a price instance can be created with a minor value of 0', function() {
+    $price = new Price(
+        type: 'selling',
+        minor: 0,
+        currency: 'EUR',
+        activated_at: now()->addWeek()
+    );
+
+    $this->assertNotNull($price);
+    $this->assertInstanceOf(Price::class, $price);
+    $this->assertSame('selling', $price->type);
+    $this->assertNotNull($price->amount);
+    $this->assertSame(0, $price->amount);
+    $this->assertSame('EUR', $price->currency);
+});
+
 test('a price instance can be created from a minor value using a constructor arguments array', function() {
     $price = new Price([
         'type' => 'selling',