fix(js-regex): 🐛 Fix Regex Pattern in addScripts Method #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the regular expression in the addScripts method from /<script.*<\/script>/ to /<script([^]*)<\/script>/. This change ensures that the script tags are correctly identified, even if they span multiple lines or contain various attributes, improving the robustness of the script injection process.
resources/js/Cookies.js
Outdated
| return; | ||
| } | ||
|
|
||
| data.scripts.forEach(script => { | ||
| const scriptRegex = /<script.*<\/script>/; | ||
| const scriptRegex = /<script([^]*)<\/script>/; |
There was a problem hiding this comment.
Could you please explain why a capture group would be necessary and why a negated empty set ([^]*) is better than .*? Thanks :)
There was a problem hiding this comment.
The capture group is indeed not necessary in this context. However, using a negated set like [^]* has the advantage of matching multi-line scripts. This allows us to send non-minified JavaScript code as a string across multiple lines. The negated set captures everything until it finds a specific character (if defined), which is beneficial when working with multi-line code or text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the regular expression in the addScripts method from /<script.</script>/ to /<script([^])</script>/. This change ensures that the script tags are correctly identified, even if they span multiple lines or contain various attributes, improving the robustness of the script injection process.