Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual implementation of PartialEq for Code #72

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Jul 7, 2024

Fix #55 and #28

We go from 16 failed round-trip parsing cases to 4.

Previous:

    phone_number::test::round_trip_parsing::case_02::mode_4
    phone_number::test::round_trip_parsing::case_03::mode_4
    phone_number::test::round_trip_parsing::case_04::mode_4
    phone_number::test::round_trip_parsing::case_05::mode_4
    phone_number::test::round_trip_parsing::case_06::mode_4
    phone_number::test::round_trip_parsing::case_07::mode_4
    phone_number::test::round_trip_parsing::case_08::mode_1
    phone_number::test::round_trip_parsing::case_08::mode_4
    phone_number::test::round_trip_parsing::case_09::mode_1
    phone_number::test::round_trip_parsing::case_09::mode_4
    phone_number::test::round_trip_parsing::case_10::mode_1
    phone_number::test::round_trip_parsing::case_10::mode_4
    phone_number::test::round_trip_parsing::case_11::mode_1
    phone_number::test::round_trip_parsing::case_11::mode_4

Current (only cases pertaining to #46 still remain!):

---- phone_number::test::round_trip_parsing::case_10::mode_1 stdout ----
-------------- TEST START --------------
Error: parsing +15208782491 with country hint None after formatting in International mode as +1 520-878-2491

Caused by:
    invalid country code

---- phone_number::test::round_trip_parsing::case_08::mode_1 stdout ----
-------------- TEST START --------------
Error: parsing +13459492311 with country hint None after formatting in International mode as +1 345-949-2311

Caused by:
    invalid country code

---- phone_number::test::round_trip_parsing::case_11::mode_1 stdout ----
-------------- TEST START --------------
Error: parsing +15208782491 with country hint None after formatting in International mode as +1 520-878-2491

Caused by:
    invalid country code

---- phone_number::test::round_trip_parsing::case_09::mode_1 stdout ----
-------------- TEST START --------------
Error: parsing +16137827274 with country hint None after formatting in International mode as +1 613-782-7274

Caused by:
    invalid country code


failures:
    phone_number::test::round_trip_parsing::case_08::mode_1
    phone_number::test::round_trip_parsing::case_09::mode_1
    phone_number::test::round_trip_parsing::case_10::mode_1
    phone_number::test::round_trip_parsing::case_11::mode_1

This breaks public API, so this is 0.4 material. I have some things up queue for one more 0.3 release, so let's wait a bit to merge this.

@rubdos rubdos added this to the 0.4 milestone Jul 7, 2024
@gferon gferon marked this pull request as draft July 8, 2024 15:38
@gferon
Copy link
Contributor

gferon commented Jul 8, 2024

Converting to draft so I don't merge it by accident 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PartialEq/Eq implementations do not satisfy the semantics of Eq
2 participants