Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle PNI UUID #299

Merged
merged 23 commits into from
Jul 12, 2024
Merged

Better handle PNI UUID #299

merged 23 commits into from
Jul 12, 2024

Commits on Jun 25, 2024

  1. Log failed UUID parse

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    06f883c View commit details
    Browse the repository at this point in the history

  2. Add ServiceIdType to ServiceAddress

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2061a62 View commit details
    Browse the repository at this point in the history

  3. MessageSenderError::NotFound: Return ServiceAddress instead of UUID

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f925238 View commit details
    Browse the repository at this point in the history

  4. Clippy

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9aefbf2 View commit details
    Browse the repository at this point in the history

  5. Use fewer unwraps 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a059186 View commit details
    Browse the repository at this point in the history

  6. Implement TryFrom<&ProtocolAddress> for ServiceAddress

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c13ed1e View commit details
    Browse the repository at this point in the history

  7. Remove unwrap()

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b7a0706 View commit details
    Browse the repository at this point in the history

  8. Add ServiceAddress to_service_id()

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ecc1f98 View commit details
    Browse the repository at this point in the history

  9. impl Hash for ServiceAddress

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b4e5a71 View commit details
    Browse the repository at this point in the history

  10. Don't assume ACI in Envelope debug print

    @direc85
    direc85 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    78bf513 View commit details
    Browse the repository at this point in the history

  11. Remove conflicting Default implementation 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8ab8eb1 View commit details
    Browse the repository at this point in the history

  12. Return Option<Aci/Pni>, fail cross-conversion 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    eee22cb View commit details
    Browse the repository at this point in the history

  13. Match for both Aci or Pni self-recipient 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0379807 View commit details
    Browse the repository at this point in the history

  14. Don't accidentally convert PNI ServiceAddress to ACI ProtocolAddress 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    729734c View commit details
    Browse the repository at this point in the history

  15. Remove unused code 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d912e48 View commit details
    Browse the repository at this point in the history

  16. Replace manual Hash implementation with derive 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    187d86b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'main' into handle-pni-uuid

    @direc85
    direc85 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7fce10c View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Use recipient field with destination 

    Co-authored-by: Ruben De Smet <[email protected]>
    @direc85 @rubdos
    direc85 and rubdos committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    1a5f254 View commit details
    Browse the repository at this point in the history

  2. Better explain ServiceAddress unwrap fails

    @direc85
    direc85 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    17845a0 View commit details
    Browse the repository at this point in the history

  3. Disallow assuming ACI ServiceAddress from Uuid

    @direc85
    direc85 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    7eadac0 View commit details
    Browse the repository at this point in the history

  4. Clean up try_from blocks

    @direc85
    direc85 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    95e83e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'main' into handle-pni-uuid

    @direc85
    direc85 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c5e285b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'main' into handle-pni-uuid

    @direc85
    direc85 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8b967e9 View commit details
    Browse the repository at this point in the history