Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last remaining part of signaling key #277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove last remaining part of signaling key #277

wants to merge 2 commits into from

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Jan 8, 2024

Came across this while cleaning up Whisperfish at https://gitlab.com/whisperfish/whisperfish/-/merge_requests/534

@rubdos
Copy link
Member Author

rubdos commented Jan 8, 2024

Ugh, this is more difficult than anticipated. Signal Android still has the Signaling key in the AccountAttributes, but sets this to null all the time.

@gferon
Copy link
Collaborator

gferon commented Oct 17, 2024

Ugh, this is more difficult than anticipated. Signal Android still has the Signaling key in the AccountAttributes, but sets this to null all the time.

Would adding a Option<()> field suffice? This is dumb but it'll work. We can even have a serde_json::Value set to Null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubdos @gferon