Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name attribute for grouping details elements into an exclusive accordion #9400

Merged
merged 14 commits into from
Oct 2, 2023
Merged

Add name attribute for grouping details elements into an exclusive accordion #9400

merged 14 commits into from
Oct 2, 2023
+261 −16

Commits on Jun 6, 2023

  1. Add name attribute for grouping details elements into an exclusive ac… 

    …cordion.
    @dbaron
    dbaron committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    c88bbf7 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Address style/markup/typo review comments (many of which were suggest… 

    …ions).
    @dbaron
    dbaron committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8639043 View commit details
    Browse the repository at this point in the history

  2. Convert both old and new open attribute change handling to be attribu… 

    …te change steps.
    @dbaron
    dbaron committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    cba81a3 View commit details
    Browse the repository at this point in the history

  3. Add exclusive accordion example.

    @dbaron
    dbaron committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    51471c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Address the straightforward comments from the new round of review.

    @dbaron
    dbaron committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    40c8996 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Address review comments from @annevk.

    @dbaron
    dbaron committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    5134538 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Add author conformance requirements.

    @dbaron
    dbaron committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    8d04f03 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Enforce exclusivity in disconnected subtrees.

    @dbaron
    dbaron committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9b76787 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'add-details-name' 

    This involves substantive merging with ToggleEvent firing changes in
32f1ec8 and
2731c29.
    @dbaron
    dbaron committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b7042fa View commit details
    Browse the repository at this point in the history

  2. Strictly enforce exclusivity for <details name>. 

    This is as proposed in
openui/open-ui#786 (comment)
    @dbaron
    dbaron committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b945c9c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Address review comments from @domenic.

    @dbaron
    dbaron committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    20490af View commit details
    Browse the repository at this point in the history

  2. Update note explaining authoring requirement to reflect exclusivity e… 

    …nforcement changes.
    @dbaron
    dbaron committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0c64396 View commit details
    Browse the repository at this point in the history

  3. Add a should (with explanatory note) about keeping related elements t… 

    …ogether.
    @dbaron
    dbaron committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    65a26ed View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Address review comments from @domenic, including more suppression of … 

    …mutation events.
    @dbaron
    dbaron committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e3ede80 View commit details
    Browse the repository at this point in the history