Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goals and Historical sections #918

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 6, 2020

Now that the relevant W3C documents redirect here, there is no need to explain the difference.

(I'm also getting reference errors, e.g., in #819.)


Preview | Diff

Now that the relevant W3C documents redirect here, there is no need to explain the difference.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I find the list of things that were explicitly removed kind of helpful... some of it could be cleaned up, e.g. things now defined elsewhere, and in general some of the section tries to act like a changelog, and there's no way that changelog is up to date.

But, explaining that we successfully removed getUserData()/xmlEncoding/setIdAttribute()/etc. seems good for people who might be coming from Java or similar? And it's kind of similar to HTML's https://html.spec.whatwg.org/#non-conforming-features section.

So my preference would be to remove the Goals section, and morph the Historical section to just list all the removed interfaces/attributes/operations, broken down by interface. You could do so without referencing what specs they were originally in, just an intro sentence saying "previous DOM specifications" or something like that.

WDYT?

@annevk
Copy link
Member Author

annevk commented Nov 9, 2020

Yeah, that's fair. I still think we should clean up the words used in HTML as obsolete is really confusing for things not actually gone. I think I'm personally settling on "legacy" for "don't like/redundant, but have to keep around" and "historical" for "gone".

@annevk annevk requested a review from domenic November 9, 2020 11:08
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It like the rename to legacy!

dom.bs Outdated
<h3 id=dom-events-changes>DOM Events</h3>
<p id=domstringlist>Contrary to earlier revisions of this standard, {{DOMString}}, {{DOMException}},
and {{DOMTimeStamp}} are now defined in Web IDL. {{DOMStringList}} is now defined in HTML.
[[WEBIDL]] [[HTML]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd lean toward omitting these too, since they have a home that people can find without too much effort. It's the ones that totally disappeared that it seems nice to keep some record of. (But, no big deal either way.)

@annevk annevk merged commit 66d6037 into master Nov 9, 2020
@annevk annevk deleted the annevk/goals-historical branch November 9, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants