Support for Account Creation Plugins #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafuga
force-pushed
the
added-account-creation-plugins
branch
from
04f8ed1
to
d45a63e
Compare
dafuga
force-pushed
the
added-account-creation-plugins
branch
from
d45a63e
to
6c172c3
Compare
dafuga
force-pushed
the
added-account-creation-plugins
branch
from
c0e6bd8
to
1257ded
Compare
dafuga
force-pushed
the
added-account-creation-plugins
branch
4 times, most recently
from
9762e4b
to
060745c
Compare
dafuga
force-pushed
the
added-account-creation-plugins
branch
from
060745c
to
b9216b5
Compare
dafuga
force-pushed
the
added-account-creation-plugins
branch
from
30c1012
to
90d9d96
Compare
This adds a lot of complexity for very little gain in the account creation flow.
aaroncox
changed the title
aaroncox
added a commit
that referenced
this pull request
Nov 10, 2023
* Added MOCK_DIR to coverage build * Allow passing a `ChainDefinition` to login as `chain` * Remove broken browser test build * Allow passing in Contract instances for ABI caching * Version 1.1.0-rc1 * Version 1.1.0-rc2 * Updating dependencies * Updated tests for compressed transactions * Added package resolution for next build * Moved ABICache mechanisms out to its own function Also implemented caching from embedded Action objects from new wharfkit/antelope release. * Updating dependencies and tests for ABI caching * Each `WalletPlugin` may optionally return an `IdentityProof` Related to #72 * Allow calling `restore` with a `ChainDefinition` Fixes #71 * Updating Antelope library * New test account * New `setAsDefault` parameter during login Allows the developer during a `login` call to specify whether or not this account should be the new default for `restore`. Defaults to true. * Support for Account Creation Plugins (#84) * chore: added account-creation plugins * fix: getting createAccount method working * fix: fixed prompts * fix: adding account creation plugins to context * fix: adding account creation method to ui interface * chore: added onAccountCreateComplete * Ran `make format` * Linting * Require a name for creation services * Mocked account creation methods in tests * Linting * Removed selected plugin from context * Swapped chain to Checksum256Type * Removed chains * Linting * Removed chains from options This adds a lot of complexity for very little gain in the account creation flow. * Reworked createAccount flow * Version 1.1.0-rc3 * Allow developer to override chain/plugin for Account Creation * Version 1.1.0-rc4 * Filter chains based on plugin capabilities, if set --------- Co-authored-by: Aaron Cox <[email protected]> * Updating dependencies for 1.1.0 * Added missing mock data --------- Co-authored-by: Daniel Fugere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.