This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
feat: add WalletConnect v2 support to Ledger connector #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ebfacc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +502 B (+1%) Total Size: 59.7 kB
ℹ️ View Unchanged
|
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
hlopes-ledger
force-pushed
the
feat/add-wc-v2-to-ledger
branch
from
40d0c55
to
b0a783f
Compare
hlopes-ledger
changed the title
hlopes-ledger
force-pushed
the
feat/add-wc-v2-to-ledger
branch
from
b0a783f
to
6c2e8a8
Compare
hlopes-ledger
force-pushed
the
feat/add-wc-v2-to-ledger
branch
3 times, most recently
from
7cf0fb3
to
9cc8d64
Compare
hlopes-ledger
force-pushed
the
feat/add-wc-v2-to-ledger
branch
from
9cc8d64
to
6d40f1c
Compare
jxom
reviewed
Jun 21, 2023
Comment on lines
+26
to
+31
| projectId?: EthereumProviderOptions['projectId'] | ||
| requiredChains?: number[] | ||
| requiredMethods?: string[] | ||
| optionalMethods?: string[] | ||
| requiredEvents?: string[] | ||
| optionalEvents?: string[] |
There was a problem hiding this comment.
Can we use a discrimitive union for these? ie:
type LedgerConnectorOptions = {
walletConnectVersion: 1,
... // v1 opts
} | {
walletConnectVersion: 2,
... // v2 opts
}There was a problem hiding this comment.
Actually, should we even support v1 in this PR at all if it's being turned off next week?
There was a problem hiding this comment.
I'll update it.
From what I've seen on the community you'll still be able to use v1 with a custom bridge URL, by specifying it in the bridge parameter. We intend to keep it for now and move to v2 only at a later stage.
|
We've released Connect Kit 1.1.0 and I've updated the package dependency. |
hlopes-ledger
force-pushed
the
feat/add-wc-v2-to-ledger
branch
from
d29babc
to
0ebfacc
Compare
jxom
approved these changes
Jun 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for WalletConnect v2 to the Ledger connector.
The Ledger Connect Kit is currently in beta, will update package.json to the final one when released. No changes expected to the connector until the final CK release.
The update enables new options for WalletConnect v2
Support for WalletConnect v1 is still kept as it can be used by specifying a custom bridge URL.
To test it
update the connector instance on the demo with the new options
Ledger Extension on Safari
WalletConnect and Ledger Live
Additional Information