Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Notification count badge #9124

Merged
merged 13 commits into from
Sep 29, 2024
Merged

fix: Notification count badge #9124

merged 13 commits into from
Sep 29, 2024

Conversation

shironegi39
Copy link
Contributor

@shironegi39 shironegi39 commented Sep 13, 2024 •
edited
Loading

タスク

バグ・不一致 #138463 [in-app-notification] 通知をクリックした時にカウントバッジがきえてしまう
┗ #153969
┗ #154063

対応した点

  • サイドバーの通知 icon をクリックした際にカウントバッジが消えてしまう

改善点

  • サイドバーの通知 icon をクリックした際にカウントバッジがリセットされないように修正
  • 未読の通知をクリックした際に count を同期させ 未読状態の通知を カウントバッジの値を sync させるように修正
  • UNREAD を廃止
    • UNOPENED に変更

操作画面

2024-09-18.130316.mp4

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4a173cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shironegi39 shironegi39 marked this pull request as ready for review September 18, 2024 05:37
@miya miya requested review from miya and yuki-takei and removed request for miya September 25, 2024 05:00
yuki-takei
yuki-takei requested changes Sep 25, 2024
View reviewed changes
...rc/migrations/20240924181317-changed-status-in-inappnotifications-from-unread-to-unopened.js

const unreadInAppnotifications = await await db.collection('inappnotifications');
await unreadInAppnotifications.updateMany(
{ status: { $eq: 'UNREAD' } },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいけど値は InAppNotificationStatuses.STATUS_UNREAD を入れましょう
下の 'UNOPENED' も同じ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string のままでよいとのことなのでそのまま

@yuki-takei yuki-takei changed the base branch from master to dev/7.1.x September 25, 2024 11:52
@shironegi39 shironegi39 changed the base branch from dev/7.1.x to master September 26, 2024 03:55
@shironegi39 shironegi39 changed the base branch from master to dev/7.1.x September 26, 2024 04:07
@miya
Copy link
Member

miya commented Sep 26, 2024

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024 •
edited by shironegi39
Loading

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • check-success ~= ci-app-launch-dev
      • check-success ~= ci-app-lint
      • check-success ~= ci-app-test
      • -check-failure ~= ci-app-
      • -check-failure ~= ci-slackbot-
      • -check-failure ~= test-prod-node20 /
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@shironegi39
Copy link
Contributor Author

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • check-success ~= ci-app-launch-dev
      • check-success ~= ci-app-lint
      • check-success ~= ci-app-test
      • -check-failure ~= ci-app-
      • -check-failure ~= ci-slackbot-
      • -check-failure ~= test-prod-node20 /
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@yuki-takei yuki-takei merged commit 67c9467 into dev/7.1.x Sep 29, 2024
10 checks passed
@yuki-takei yuki-takei deleted the fix/138463-153969-fix-notification-count-badge branch September 29, 2024 18:32
@github-actions github-actions bot mentioned this pull request Sep 29, 2024
Closed
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Closed
This was referenced Oct 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-takei yuki-takei yuki-takei requested changes

@miya miya Awaiting requested review from miya

Assignees
No one assigned
Labels
type/bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shironegi39 @miya @yuki-takei