Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make CustomNavTab responsive #9123

Merged
merged 15 commits into from
Sep 24, 2024
Merged

fix: Make CustomNavTab responsive #9123

merged 15 commits into from
Sep 24, 2024

Conversation

moekumasaka
Copy link
Contributor

@moekumasaka moekumasaka commented Sep 13, 2024 •
edited
Loading

タスク

  • #114434DescendantsPageListModal.tsx を開いた状態で window サイズを縮小させるとタイムラインのタブが非表示になる

やったこと

DescendantsPageListModal

  • 画面サイズが md 以下のとき、body にドロップダウンを表示

    • このとき、タブは非表示

  • モーダル内の dropdown において、メニューをクリック時にメニューが閉じるなどの bootstrap のデフォルトの機能が動作しなかったので、モーダル側で dropdown を閉じるようなコードを書いた

  • padding などの見た目は、fumiya さんに確認してもらった

管理画面の通知設定(/admin/notification)

  • ここは /admin/security 同様に、ドロップダウンにした(ブラウザ幅を小さくしたときに、スタイルがくずれていたので)

備考

  • 最終的に PageAccessoriesModal は DescendantsPageListModal と同様の変更が加わる予定

キャプチャ

  • ページリストモーダル
image image
  • /admin/notification
image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 461ca6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@moekumasaka moekumasaka changed the title ref: 114434 CustomNavTab の改修とテスト fix: 114434 modify CustomNavTab Sep 13, 2024
@moekumasaka moekumasaka marked this pull request as draft September 13, 2024 08:26
@moekumasaka moekumasaka marked this pull request as ready for review September 18, 2024 08:04
@yuki-takei yuki-takei changed the title fix: 114434 modify CustomNavTab fix: Make CustomNavTab responsive Sep 19, 2024
yuki-takei
yuki-takei requested changes Sep 19, 2024
View reviewed changes
apps/app/src/client/components/CustomNavigation/CustomNav.module.scss Outdated

.dropdown-menu :global {
width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • width: 100% はユーティリティクラスでどうにかなるはず
  • オリジナルのクラスを宣言する必要があるのであれば一般的なクラス名を避けてください

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w-100 を追加するように修正しました。

mergify bot added a commit that referenced this pull request Sep 24, 2024
@mergify
Merge of #9123
804f1d3
@mergify mergify bot mentioned this pull request Sep 24, 2024
Closed
15 tasks
@yuki-takei
Copy link
Member

yuki-takei commented Sep 24, 2024 •
edited
Loading

Approved
merge 待ち

@mergify mergify bot merged commit d68a7dd into master Sep 24, 2024
17 checks passed
@mergify mergify bot deleted the fix/114434-153937-pagelistmodal-navtab branch September 24, 2024 08:54
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Merged
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Closed
This was referenced Oct 16, 2024
Closed
Merged
@yuki-takei yuki-takei mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-takei yuki-takei yuki-takei approved these changes

Assignees
No one assigned
Labels
type/bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moekumasaka @yuki-takei