Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: The color of the dropdown list when it is activated #9102

Conversation

WNomunomu
Copy link
Contributor

@WNomunomu WNomunomu commented Sep 12, 2024

タスク

  • #142193 [v7]ドロップダウンなどのリストのクリック時の色を改善する

概要

  • ドロップダウンリストのクリック時の色がテーマにかかわらずbsデフォルトの青色から、適切な色に変更しました。

なお、設定した色についてはfumiya-sの承認をいただいています。

変更点

  • _dropdown.scss を作成し、全dropdownに共通でactive時のstyleが適用されるようにしました。

セルフチェック

  • コンフリクト解消したか
  • 余計なコードは残っていないか
  • 適切にメモ化したか
  • 責務の問題はクリアしているか
  • CIは通っているか
  • PRの内容は適切にかけているか

Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 17a35ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@yuki-takei yuki-takei Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap のコンポーネントの色変更は packages/core-styles/scss/bootstrap/theming 内でやってください

@yuki-takei yuki-takei changed the title imprv: the color of the dropdown list when it is clicked imprv: The color of the dropdown list when it is activated Sep 16, 2024
@use '@growi/core-styles/scss/bootstrap/init' as bs;

.dropdown-item:active{
--#{$prefix}dropdown-link-active-bg: #{( bs.$gray-700 )};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

値の指定には #{{ bs.$gray-* }} ではなく var(-bs-gray-*) を使ってください

@miya
Copy link
Member

miya commented Sep 23, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Sep 23, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Sep 23, 2024
@yuki-takei
Copy link
Member

@mergify requeue

@yuki-takei
Copy link
Member

@mergify queue

Copy link
Contributor

mergify bot commented Sep 24, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Copy link
Contributor

mergify bot commented Sep 24, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 45a3b9f

mergify bot added a commit that referenced this pull request Sep 24, 2024
@mergify mergify bot merged commit 45a3b9f into master Sep 24, 2024
16 checks passed
@mergify mergify bot deleted the imprv/142193-153946-the-color-of-the-dropdown-list-when-it-is-clicked branch September 24, 2024 13:43
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
This was referenced Oct 16, 2024
@yuki-takei yuki-takei mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants