Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PageControls unexpectedly move in response to opening and closing the sidebar #9094

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WNomunomu
Copy link
Contributor

@WNomunomu WNomunomu commented Sep 11, 2024

タスク

  • #144917 サイドバーの開閉に合わせてPageControlsが想定外の場所に移動する

概要

  • サイドバーの開閉に合わせて PageControls も正しい位置に動くようにしました。

変更点

  • Stickyコンポーネントの innerActiveClass props に class を新しく指定しました。

セルフチェック

  • コンフリクト解消したか
  • 余計なコードは残っていないか
  • 適切にメモ化したか
  • 責務の問題はクリアしているか
  • CIは通っているか
  • PRの内容は適切にかけているか

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: fe3ad75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yuki-takei yuki-takei changed the title fix: the issue where the PageControls unexpectedly move in response to opening and closing the sidebar fix: PageControls unexpectedly move in response to opening and closing the sidebar Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants