-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imprv: Add types to remark-growi-directive #9025
imprv: Add types to remark-growi-directive #9025
Conversation
…148445-151932-add-type-remark-growi-directive
…5-151932-add-type-remark-growi-directive
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これは index.d.ts 相当だよね?
なるべく syntax-tree/mdast-util-directive のディレクトリ構造(モジュール構成)を保ってほしい
将来的にまたメジャーバージョンアップ等があって追従する時に対応を読み解くのが大変になるので
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.d.ts
だと dist 配下に出力されなかったので、index.ts
で代用しています。ただ、ディレクトリ構造を同じようにするために、 index.js
を追加しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.js と index.ts を共存させる構成は一般的ではないので、やはり index.d.ts にしてください
dist へのコピーは tsc が走ったあとに shx cp
するなどして
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.d.ts に変更しました。コピーについては、apps/slackbot-proxy/package.json を参考に、yarn cp
を使用しました
de819f5
into
imprv/148445-upgrade-remark-growi-directive
Summary
Task
Note