Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Add types to remark-growi-directive #9025

Conversation

reiji-h
Copy link
Contributor

@reiji-h reiji-h commented Aug 13, 2024

Summary

  • remark-growi-directive に対して型情報を追加する

Task

Note

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: 1834459

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@reiji-h reiji-h marked this pull request as draft August 13, 2024 07:20
packages/remark-growi-directive/tsconfig.build.json Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは index.d.ts 相当だよね?
なるべく syntax-tree/mdast-util-directive のディレクトリ構造(モジュール構成)を保ってほしい
将来的にまたメジャーバージョンアップ等があって追従する時に対応を読み解くのが大変になるので

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.d.ts だと dist 配下に出力されなかったので、index.ts で代用しています。ただ、ディレクトリ構造を同じようにするために、 index.js を追加しました。

Base automatically changed from imprv/148445-15079-update-dependencies to imprv/148445-upgrade-remark-growi-directive August 26, 2024 06:34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.js と index.ts を共存させる構成は一般的ではないので、やはり index.d.ts にしてください
dist へのコピーは tsc が走ったあとに shx cp するなどして

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.d.ts に変更しました。コピーについては、apps/slackbot-proxy/package.json を参考に、yarn cp を使用しました

@reiji-h reiji-h marked this pull request as ready for review August 26, 2024 09:13
@reiji-h reiji-h merged commit de819f5 into imprv/148445-upgrade-remark-growi-directive Aug 26, 2024
3 of 5 checks passed
@reiji-h reiji-h deleted the impv/148445-151932-add-type-remark-growi-directive branch August 26, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants