reuse existing upload on duplicate request #8999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…nto feat/147526-151412-reuse-upload-on-duplicate-request
…nto feat/147526-151412-reuse-upload-on-duplicate-request
…nto feat/147526-151412-reuse-upload-on-duplicate-request
…nto feat/147526-151412-reuse-upload-on-duplicate-request
Base automatically changed from
feat/78039-151411-cancel-streams-on-export-job-abort
to
feat/page-bulk-export
August 26, 2024 09:34
…nto feat/147526-151412-reuse-upload-on-duplicate-request
yuki-takei
requested changes
Aug 26, 2024
| @@ -188,6 +207,9 @@ class PageBulkExportService { | |||
| objectMode: true, | |||
| write: async(page: PageDocument, encoding, callback) => { | |||
| try { | |||
| if (page.revision != null) { | |||
| revisionListHash.update(getIdForRef(page.revision).toString()); | |||
There was a problem hiding this comment.
現在は getIdStringForRef というのがあります
arafubeatbox
deleted the
feat/147526-151412-reuse-upload-on-duplicate-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実装方針
task
https://redmine.weseek.co.jp/issues/151412