Feat/78039 151411 cancel streams on export job abort #8997
Conversation
|
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
apps/app/src/features/page-bulk-export/server/service/page-bulk-export/index.ts
Show resolved
Hide resolved
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
…obs' into feat/78039-151411-cancel-streams-on-export-job-abort
…reams-on-export-job-abort
| @@ -377,6 +383,8 @@ class PageBulkExportService { | |||
| * - abort multipart upload | |||
| */ | |||
| async cleanUpExportJobResources(pageBulkExportJob: PageBulkExportJobDocument) { | |||
| this.pageBulkExportJobStreamManager?.destroyJobStream(pageBulkExportJob._id); | |||
There was a problem hiding this comment.
job を cleanUp する際、実行中の stream があればそれを停止させる (実行中の stream が無くてもエラーにはならない
There was a problem hiding this comment.
pageBulkExportJobStreamManager? の ? 不要では？
| private jobStreams: Record<string, Readable> = {}; | ||
|
|
||
| addJobStream(jobId: ObjectIdLike, stream: Readable): void { | ||
| this.jobStreams[jobId.toString()] = stream; |
There was a problem hiding this comment.
add 時に既に同 ID の stream が存在していたら destroy すべきではないかな
| @@ -377,6 +383,8 @@ class PageBulkExportService { | |||
| * - abort multipart upload | |||
| */ | |||
| async cleanUpExportJobResources(pageBulkExportJob: PageBulkExportJobDocument) { | |||
| this.pageBulkExportJobStreamManager?.destroyJobStream(pageBulkExportJob._id); | |||
There was a problem hiding this comment.
pageBulkExportJobStreamManager? の ? 不要では？
arafubeatbox
deleted the
feat/78039-151411-cancel-streams-on-export-job-abort
branch
やったこと
task
https://redmine.weseek.co.jp/issues/151411