Skip to content

Commit

Permalink
bugFix
Browse files Browse the repository at this point in the history
  • Loading branch information
miya committed Apr 9, 2024
1 parent 5a5a459 commit 3a76446
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-app-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
with:
node-version: 20.x
skip-cypress: ${{ contains( github.event.pull_request.labels.*.name, 'dependencies' ) }}
cypress-report-artifact-name: Cypress report
cypress-report-artifact-name-prefix: Cypress report
cypress-config-video: ${{ inputs.cypress-config-video || false }}
secrets:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
Expand All @@ -78,7 +78,7 @@ jobs:
with:
node-version: 20.x
skip-reg-suit: ${{ contains( github.event.pull_request.labels.*.name, 'dependencies' ) }}
cypress-report-artifact-name: Cypress report
cypress-report-artifact-name-pattern: Cypress report-*
secrets:
REG_NOTIFY_GITHUB_PLUGIN_CLIENTID: ${{ secrets.REG_NOTIFY_GITHUB_PLUGIN_CLIENTID }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reusable-app-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
type: string
skip-cypress:
type: boolean
cypress-report-artifact-name:
cypress-report-artifact-name-prefix:
type: string
cypress-config-video:
type: boolean
Expand Down Expand Up @@ -326,7 +326,7 @@ jobs:
if: always()
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.cypress-report-artifact-name }}
name: ${{ cypress-report-artifact-name-prefix }}-${{ matrix.spec-group }}
path: |
apps/app/test/cypress/screenshots
apps/app/test/cypress/videos
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/reusable-app-reg-suit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
default: ${{ github.head_ref }}
skip-reg-suit:
type: boolean
cypress-report-artifact-name:
cypress-report-artifact-name-pattern:
required: true
type: string
secrets:
Expand Down Expand Up @@ -88,8 +88,9 @@ jobs:
- name: Download screenshots taken by cypress
uses: actions/download-artifact@v4
with:
name: ${{ inputs.cypress-report-artifact-name }}
path: apps/app/test/cypress
pattern: ${{ inputs.cypress-report-artifact-name-pattern }}
merge-multiple: true

- name: Run reg-suit
working-directory: ./apps/app
Expand Down

0 comments on commit 3a76446

Please sign in to comment.