Skip to content

Commit

Permalink
Merge pull request #9018 from weseek/support/update-import-lines
Browse files Browse the repository at this point in the history
support: Update import lines
  • Loading branch information
yuki-takei committed Aug 7, 2024
2 parents e70b00d + 1502b20 commit 26375b7
Show file tree
Hide file tree
Showing 26 changed files with 53 additions and 43 deletions.
4 changes: 2 additions & 2 deletions apps/app/src/interfaces/crowi-request.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import type { IUser } from '@growi/core';
import type { Request } from 'express';
import type { Document } from 'mongoose';
import type { HydratedDocument } from 'mongoose';


export interface CrowiProperties {

user?: IUser & Document,
user?: HydratedDocument<IUser>,

// eslint-disable-next-line @typescript-eslint/no-explicit-any
crowi: any,
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/models/attachment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'path';
import type { IAttachment } from '@growi/core';
import { addSeconds } from 'date-fns/addSeconds';
import {
Schema, type Model, type Document, Types,
Schema, type Model, type Document,
} from 'mongoose';
import mongoosePaginate from 'mongoose-paginate-v2';
import uniqueValidator from 'mongoose-unique-validator';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/routes/apiv3/customize-setting.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import multer from 'multer';
import { GrowiPlugin } from '~/features/growi-plugin/server/models';
import { SupportedAction } from '~/interfaces/activity';
import { AttachmentType } from '~/server/interfaces/attachment';
import { Attachment } from '~/server/models';
import { Attachment } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { generateAddActivityMiddleware } from '../../middlewares/add-activity';
Expand Down
13 changes: 8 additions & 5 deletions apps/app/src/server/routes/apiv3/g2g-transfer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,23 @@ import { createReadStream } from 'fs';
import path from 'path';

import { ErrorV3 } from '@growi/core/dist/models';
import express, { NextFunction, Request, Router } from 'express';
import type { NextFunction, Request, Router } from 'express';
import express from 'express';
import { body } from 'express-validator';
import multer from 'multer';

import { isG2GTransferError } from '~/server/models/vo/g2g-transfer-error';
import { IDataGROWIInfo, X_GROWI_TRANSFER_KEY_HEADER_NAME } from '~/server/service/g2g-transfer';
import { configManager } from '~/server/service/config-manager';
import type { IDataGROWIInfo } from '~/server/service/g2g-transfer';
import { X_GROWI_TRANSFER_KEY_HEADER_NAME } from '~/server/service/g2g-transfer';
import loggerFactory from '~/utils/logger';
import { TransferKey } from '~/utils/vo/transfer-key';


import Crowi from '../../crowi';
import type Crowi from '../../crowi';
import { apiV3FormValidator } from '../../middlewares/apiv3-form-validator';

import { ApiV3Response } from './interfaces/apiv3-response';
import type { ApiV3Response } from './interfaces/apiv3-response';

interface AuthorizedRequest extends Request {
user?: any
Expand All @@ -37,7 +40,7 @@ const validator = {
module.exports = (crowi: Crowi): Router => {
const {
g2gTransferPusherService, g2gTransferReceiverService, exportService, importService,
growiBridgeService, configManager,
growiBridgeService,
} = crowi;
if (g2gTransferPusherService == null || g2gTransferReceiverService == null || exportService == null || importService == null
|| growiBridgeService == null || configManager == null) {
Expand Down
13 changes: 9 additions & 4 deletions apps/app/src/server/routes/apiv3/invited.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
import express, { Request, Router } from 'express';
import type { IUser } from '@growi/core';
import type { Request, Router } from 'express';
import express from 'express';
import mongoose from 'mongoose';

import Crowi from '../../crowi';
import type Crowi from '../../crowi';
import { invitedRules, invitedValidation } from '../../middlewares/invited-form-validator';

import { ApiV3Response } from './interfaces/apiv3-response';
import type { ApiV3Response } from './interfaces/apiv3-response';

type InvitedFormRequest = Request & { form: any, user: any };

module.exports = (crowi: Crowi): Router => {
const applicationInstalled = require('../../middlewares/application-installed')(crowi);
const debug = require('debug')('growi:routes:login');
const User = crowi.model('User');
const router = express.Router();

router.post('/', applicationInstalled, invitedRules(), invitedValidation, async(req: InvitedFormRequest, res: ApiV3Response) => {
Expand All @@ -22,6 +24,9 @@ module.exports = (crowi: Crowi): Router => {
return res.apiv3Err(req.form.errors, 400);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const User = mongoose.model<IUser, any>('User');

const user = req.user;
const invitedForm = req.form.invitedForm || {};
const username = invitedForm.username;
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/routes/apiv3/notification-setting.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ErrorV3 } from '@growi/core/dist/models';

import { SupportedAction } from '~/interfaces/activity';
import { GlobalNotificationSettingType } from '~/server/models';
import { GlobalNotificationSettingType } from '~/server/models/GlobalNotificationSetting';
import loggerFactory from '~/utils/logger';
import { removeNullPropertyFromObject } from '~/utils/object-utils';

Expand Down
8 changes: 4 additions & 4 deletions apps/app/src/server/routes/apiv3/page-listing.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {
IPageInfoForListing, IPageInfo,
IPageInfoForListing, IPageInfo, IPage,
} from '@growi/core';
import { getIdForRef, isIPageInfoForEntity } from '@growi/core';
import { ErrorV3 } from '@growi/core/dist/models';
Expand All @@ -9,7 +9,6 @@ import { query, oneOf } from 'express-validator';
import type { HydratedDocument } from 'mongoose';
import mongoose from 'mongoose';


import type { IPageGrantService } from '~/server/service/page-grant';
import loggerFactory from '~/utils/logger';

Expand Down Expand Up @@ -66,7 +65,7 @@ const routerFactory = (crowi: Crowi): Router => {


router.get('/root', accessTokenParser, loginRequired, async(req: AuthorizedRequest, res: ApiV3Response) => {
const Page: PageModel = crowi.model('Page');
const Page = mongoose.model<IPage, PageModel>('Page');

let rootPage;
try {
Expand Down Expand Up @@ -124,7 +123,8 @@ const routerFactory = (crowi: Crowi): Router => {
const attachShortBody: boolean = attachShortBodyParam === 'true';

const Page = mongoose.model<HydratedDocument<PageDocument>, PageModel>('Page');
const Bookmark = crowi.model('Bookmark');
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const Bookmark = mongoose.model<any, any>('Bookmark');
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const pageService = crowi.pageService;
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/routes/attachment/get-brand-logo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import loggerFactory from '~/utils/logger';
import type Crowi from '../../crowi';
import { AttachmentType } from '../../interfaces/attachment';
import { generateCertifyBrandLogoMiddleware } from '../../middlewares/certify-brand-logo';
import { Attachment } from '../../models';
import { Attachment } from '../../models/attachment';
import ApiResponse from '../../util/apiResponse';

import { getActionFactory } from './get';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/routes/attachment/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import loggerFactory from '~/utils/logger';

import type Crowi from '../../crowi';
import { certifySharedPageAttachmentMiddleware } from '../../middlewares/certify-shared-page-attachment';
import { Attachment, type IAttachmentDocument } from '../../models';
import { Attachment, type IAttachmentDocument } from '../../models/attachment';
import ApiResponse from '../../util/apiResponse';


Expand Down
7 changes: 4 additions & 3 deletions apps/app/src/server/routes/ogp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ import path from 'path';
import { DevidedPagePath } from '@growi/core/dist/models';
// eslint-disable-next-line no-restricted-imports
import axios from 'axios';
import {
import type {
Request, Response, NextFunction,
} from 'express';
import { param, validationResult, ValidationError } from 'express-validator';
import type { ValidationError } from 'express-validator';
import { param, validationResult } from 'express-validator';

import loggerFactory from '~/utils/logger';
import { projectRoot } from '~/utils/project-dir-utils';

import { Attachment } from '../models';
import { Attachment } from '../models/attachment';
import { convertStreamToBuffer } from '../util/stream';

const logger = loggerFactory('growi:routes:ogp');
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/routes/page.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import mongoose from 'mongoose';

import loggerFactory from '~/utils/logger';

import { GlobalNotificationSettingEvent } from '../models';
import { GlobalNotificationSettingEvent } from '../models/GlobalNotificationSetting';
import { PathAlreadyExistsError } from '../models/errors';
import PageTagRelation from '../models/page-tag-relation';
import UpdatePost from '../models/update-post';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/attachment.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import loggerFactory from '~/utils/logger';

import { AttachmentType } from '../interfaces/attachment';
import { Attachment } from '../models';
import { Attachment } from '../models/attachment';

const fs = require('fs');

Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/aws.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { getSignedUrl } from '@aws-sdk/s3-request-presigner';
import urljoin from 'url-join';

import { ResponseMode, type RespondOptions } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models';
import type { IAttachmentDocument } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { configManager } from '../config-manager';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/azure.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
} from '@azure/storage-blob';

import { ResponseMode, type RespondOptions } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models';
import type { IAttachmentDocument } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { configManager } from '../config-manager';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/file-uploader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { Response } from 'express';

import type { ICheckLimitResult } from '~/interfaces/attachment';
import { type RespondOptions, ResponseMode } from '~/server/interfaces/attachment';
import { Attachment, type IAttachmentDocument } from '~/server/models';
import { Attachment, type IAttachmentDocument } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { configManager } from '../config-manager';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/gcs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import urljoin from 'url-join';

import type Crowi from '~/server/crowi';
import { ResponseMode, type RespondOptions } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models';
import type { IAttachmentDocument } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { configManager } from '../config-manager';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/gridfs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import mongoose from 'mongoose';
import { createModel } from 'mongoose-gridfs';

import type { RespondOptions } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models';
import type { IAttachmentDocument } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { configManager } from '../config-manager';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/local.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Readable } from 'stream';
import type { Response } from 'express';

import { ResponseMode, type RespondOptions } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models';
import type { IAttachmentDocument } from '~/server/models/attachment';
import loggerFactory from '~/utils/logger';

import { configManager } from '../config-manager';
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/file-uploader/utils/headers.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Response } from 'express';

import type { ExpressHttpHeader, IContentHeaders } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models';
import type { IAttachmentDocument } from '~/server/models/attachment';


export class ContentHeaders implements IContentHeaders {
Expand Down
9 changes: 6 additions & 3 deletions apps/app/src/server/service/g2g-transfer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ import { basename } from 'path';
import type { Readable } from 'stream';

// eslint-disable-next-line no-restricted-imports
import type { IUser } from '@growi/core';
import rawAxios, { type AxiosRequestConfig } from 'axios';
import FormData from 'form-data';
import { Types as MongooseTypes } from 'mongoose';
import mongoose, { Types as MongooseTypes } from 'mongoose';

import { G2G_PROGRESS_STATUS } from '~/interfaces/g2g-transfer';
import GrowiArchiveImportOption from '~/models/admin/growi-archive-import-option';
Expand All @@ -19,7 +20,7 @@ import loggerFactory from '~/utils/logger';
import { TransferKey } from '~/utils/vo/transfer-key';

import type Crowi from '../crowi';
import { Attachment } from '../models';
import { Attachment } from '../models/attachment';
import { G2GTransferError, G2GTransferErrorCode } from '../models/vo/g2g-transfer-error';

import { configManager } from './config-manager';
Expand Down Expand Up @@ -257,7 +258,9 @@ export class G2GTransferPusherService implements Pusher {
};
}

const activeUserCount = await this.crowi.model('User').countActiveUsers();
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const User = mongoose.model<IUser, any>('User');
const activeUserCount = await User.countActiveUsers();
if ((destGROWIInfo.userUpperLimit ?? Infinity) < activeUserCount) {
return {
canTransfer: false,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import nodePath from 'path';

import { GlobalNotificationSettingEvent, GlobalNotificationSettingType } from '~/server/models';
import { GlobalNotificationSettingEvent, GlobalNotificationSettingType } from '~/server/models/GlobalNotificationSetting';
import { configManager } from '~/server/service/config-manager';
import loggerFactory from '~/utils/logger';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { pagePathUtils } from '@growi/core/dist/utils';

import { GlobalNotificationSettingEvent, GlobalNotificationSettingType } from '~/server/models';
import { GlobalNotificationSettingEvent, GlobalNotificationSettingType } from '~/server/models/GlobalNotificationSetting';
import loggerFactory from '~/utils/logger';

import {
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/pre-notify.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type {
IPage, IUser, Ref,
} from '@growi/core';

import { ActivityDocument } from '../models/activity';
import type { ActivityDocument } from '../models/activity';
import Subscription from '../models/subscription';
import { getModelSafely } from '../util/mongoose-utils';

Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/server/service/slack-command-handler/keep.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import {
import { format } from 'date-fns/format';
import { parse } from 'date-fns/parse';

import { SlackCommandHandlerError } from '~/server/models/vo/slack-command-handler-error';
import loggerFactory from '~/utils/logger';

const logger = loggerFactory('growi:service:SlackBotService:keep');

const { SlackCommandHandlerError } = require('../../models/vo/slack-command-handler-error');

module.exports = (crowi) => {
const CreatePageService = require('./create-page-service');
Expand Down
3 changes: 1 addition & 2 deletions apps/app/src/server/service/slack-command-handler/note.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ import {
markdownHeaderBlock, inputSectionBlock, inputBlock, actionsBlock, buttonElement,
} from '@growi/slack/dist/utils/block-kit-builder';

import { SlackCommandHandlerError } from '~/server/models/vo/slack-command-handler-error';
import loggerFactory from '~/utils/logger';

const { SlackCommandHandlerError } = require('../../models/vo/slack-command-handler-error');

const logger = loggerFactory('growi:service:SlackCommandHandler:note');

module.exports = (crowi) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@ import { respond, deleteOriginal } from '@growi/slack/dist/utils/response-url';
import { format, formatDate } from 'date-fns/format';
import { parse } from 'date-fns/parse';

import { SlackCommandHandlerError } from '~/server/models/vo/slack-command-handler-error';
import loggerFactory from '~/utils/logger';

// eslint-disable-next-line no-unused-vars
const logger = loggerFactory('growi:service:SlackBotService:togetter');


const { SlackCommandHandlerError } = require('../../models/vo/slack-command-handler-error');

module.exports = (crowi) => {
const CreatePageService = require('./create-page-service');
const createPageService = new CreatePageService(crowi);
Expand Down

0 comments on commit 26375b7

Please sign in to comment.