Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] support diar #246

Merged
merged 6 commits into from
Dec 29, 2023
Merged

[cli] support diar #246

merged 6 commits into from
Dec 29, 2023

Conversation

cdliang11
Copy link
Collaborator

wespeaker --task diarization --audio_file /Users/user01/Downloads/voxconverse_test_wav/aepyx.wav --language english
image

@cdliang11
Copy link
Collaborator Author

cdliang11 commented Dec 27, 2023

先不要合入,有几点需要确认:

  1. diar相关的参数比较多,是通过配置文件的形式传入 还是 命令行传参?

@wsstriving
Copy link
Collaborator

先不要合入,有几点需要确认:

  1. diar相关的参数比较多,是通过配置文件的形式传入 还是 命令行传参?

感觉命令行比较好?设置一些默认的,不过在readme 里边写清楚;现在这个效果咋样?

@cdliang11
Copy link
Collaborator Author

先不要合入,有几点需要确认:

  1. diar相关的参数比较多,是通过配置文件的形式传入 还是 命令行传参?

感觉命令行比较好?设置一些默认的,不过在readme 里边写清楚;现在这个效果咋样?

没有大规模测试,现在的默认参数和example/voxconverse/v2一致,效果应该和v2的结果一致

@cdliang11
Copy link
Collaborator Author

cdliang11 commented Dec 28, 2023

TODO:

  • 暴露diar相关参数的设置接口
  • 性能测试

@JiJiJiang
Copy link
Collaborator

JiJiJiang commented Dec 28, 2023

TODO:

  • 暴露diar相关参数的设置接口
  • 性能测试

基本是从v2改过来的,可以直接拿一两条voxconverse的音频,结果基本能对上就可以了,不一定要测DER

Copy link
Collaborator

@JiJiJiang JiJiJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:不建议从v2里面单独拎几个func出来新建utils/diar_utils.py,更没必要单独新建utils/cluster.py,还是直接import v2里面的func即可

@cdliang11
Copy link
Collaborator Author

cdliang11 commented Dec 28, 2023

TODO:不建议从v2里面单独拎几个func出来新建utils/diar_utils.py,更没必要单独新建utils/cluster.py,还是直接import v2里面的func即可

这样的话打pip包会不方便。 原则上wespeaker/下边放代码,example下放私有的代码,之前diar相关的代码都放在example下了,要不趁机重构下

@JiJiJiang JiJiJiang marked this pull request as draft December 29, 2023 03:02
@JiJiJiang JiJiJiang marked this pull request as ready for review December 29, 2023 03:04
@JiJiJiang JiJiJiang self-requested a review December 29, 2023 03:04
Copy link
Collaborator

@JiJiJiang JiJiJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@JiJiJiang JiJiJiang merged commit ab926d4 into master Dec 29, 2023
3 checks passed
@JiJiJiang JiJiJiang deleted the chengdong-diar branch December 29, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants