Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] add silero-vad package #241

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[doc] add silero-vad package #241

merged 1 commit into from
Nov 29, 2023

Conversation

cdliang11
Copy link
Collaborator

@cdliang11 cdliang11 commented Nov 29, 2023 •
edited
Loading

wespeaker/wespeaker/__init__.py

Lines 1 to 2 in 1baf642

from wespeaker.cli.speaker import load_model # noqa
from wespeaker.cli.speaker import load_model_local # noqa

这两行代码调用了cli部分

czy97
czy97 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@czy97 czy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看了下，这个只是之前的代码import了silero-vad，但没有在requirements.txt里加这个包是吧？

@cdliang11
Copy link
Collaborator Author

我看了下，这个只是之前的代码import了silero-vad，但没有在requirements.txt里加这个包是吧？

是的

@czy97 czy97 merged commit 80b3acd into master Nov 29, 2023
3 checks passed
@czy97 czy97 deleted the chengdong-doc branch November 29, 2023 13:39
@JiJiJiang
Copy link
Collaborator

我看了下，这个只是之前的代码import了silero-vad，但没有在requirements.txt里加这个包是吧？

不用cli也一定需要install silero vad吗？是会报包丢失吗？

@cdliang11
Copy link
Collaborator Author

cdliang11 commented Nov 29, 2023 •
edited
Loading

我看了下，这个只是之前的代码import了silero-vad，但没有在requirements.txt里加这个包是吧？

不用cli也一定需要install silero vad吗？是会报包丢失吗？

wespeaker/wespeaker/__init__.py

Lines 1 to 2 in 1baf642

from wespeaker.cli.speaker import load_model # noqa
from wespeaker.cli.speaker import load_model_local # noqa

是的，会报包缺失
调用wespeaker/.. 文件夹的py文件时，wespeaker/__init__.py会先被执行，间接调用了cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy97 czy97 czy97 approved these changes

@robin1001 robin1001 Awaiting requested review from robin1001

@wsstriving wsstriving Awaiting requested review from wsstriving

@JiJiJiang JiJiJiang Awaiting requested review from JiJiJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdliang11 @JiJiJiang @czy97