warn on empty blowpipe import #396
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't fully solve the issue, since we still need to fix the import flow to preserve the blowpipe ammo, but this at least prevents users loading empty blowpipes unknowingly and seeing incorrect results. Closes #293
jayktaylor
requested changes
Jul 2, 2024
There was a problem hiding this comment.
I really don't like the current UI behaviour of this (see video below). I think two things need to happen:
- The warning should not require us to wait for a worker response before showing it. It's an issue that the frontend can raise instantly based on the current Mobx state. This would prevent the flickering seen on the video, and the shift of DOM elements around.
- If more than one "global" issue should be displayed, then we shouldn't just stack them on top of each other. It looks messy, and pushes everything down. We should re-think how the "global" issues are presented.
Also, we should change the message to something less technical, since the audience using this aren't going to understand it. Maybe:
We couldn't determine what darts your blowpipe uses. Please re-select it from the equipment dropdown.
Screen.Recording.2024-07-02.at.16.58.55.mov
LlemonDuck
added a commit
that referenced
this pull request
Jul 3, 2024
This solves the export-import portion of #293, but we still need to handle warnings. This PR could be merged in the interim since it's strictly better than existing behaviour, albeit not being a full fix. I've put this up as a separate PR from #396 in case we change the approach for errors away from that one. If we can solve the data sourcing issue in wikisync, it will also be capable of specifying the dart id through the itemVars field.
jayktaylor
pushed a commit
that referenced
this pull request
Jul 4, 2024
This solves the export-import portion of #293, but we still need to handle warnings. This PR could be merged in the interim since it's strictly better than existing behaviour, albeit not being a full fix. I've put this up as a separate PR from #396 in case we change the approach for errors away from that one. If we can solve the data sourcing issue in wikisync, it will also be capable of specifying the dart id through the itemVars field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't fully solve the issue, since we still need to fix the import flow to preserve the blowpipe ammo, but this at least prevents users loading empty blowpipes unknowingly and seeing incorrect results.
Closes #293