Using a blowpipe with no darts should be a no-op & show a warning #293
Assignees
Comments
jayktaylor
added
bug
LlemonDuck
added a commit
that referenced
this issue
Jun 24, 2024
Doesn't fully solve the issue, since we still need to fix the import flow to preserve the blowpipe ammo, but this at least prevents users loading empty blowpipes unknowingly and seeing incorrect results. Closes #293
LlemonDuck
added a commit
that referenced
this issue
Jul 3, 2024
This solves the export-import portion of #293, but we still need to handle warnings. This PR could be merged in the interim since it's strictly better than existing behaviour, albeit not being a full fix. I've put this up as a separate PR from #396 in case we change the approach for errors away from that one. If we can solve the data sourcing issue in wikisync, it will also be capable of specifying the dart id through the itemVars field.
jayktaylor
pushed a commit
that referenced
this issue
Jul 4, 2024
This solves the export-import portion of #293, but we still need to handle warnings. This PR could be merged in the interim since it's strictly better than existing behaviour, albeit not being a full fix. I've put this up as a separate PR from #396 in case we change the approach for errors away from that one. If we can solve the data sourcing issue in wikisync, it will also be capable of specifying the dart id through the itemVars field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What went wrong?
For example, opening from RuneLite will not allow us to know what darts the player is using (there is no client-side varb or varp for this, afaik), so it will open the calculator with a blowpipe equipped but no darts (runelite/runelite#17688).
What did you expect to happen?
We should essentially no-op when someone chooses the normal blowpipe with no specific ammo type, and show no DPS. We should also show a warning (probably by adding a
UserIssueType) to inform the user.What browsers are you seeing the problem on?
Firefox
What device(s) are you seeing the problem on?
Windows
Any other information
No response
The text was updated successfully, but these errors were encountered: