Add json endpoint for hiscores #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! What a quick turnaround! <3 |
|
Is there a reason we want to support both endpoints? Can you just replace the existing functionality rather than supporting both json and ws? |
|
Backwards compatibility mostly. You dont want all tools to break when we deploy this right? Or maybe you do Code would for sure be simpler if we allow only one endpoint |
|
I think it's completely fine to break backwards compatibility and forget the ws endpoint. There are so few tools that actually use this plugin, and it's a very easy fix. |
|
Closed in favor of #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested it, seems to work.