Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Recently when testing a nightly Swift snapshot in a project of mine, I came across an alignment crash. It turns out that
Data
orsubdata
point to memory with any particular alignment.T
beingUInt32
, thesubdata
was in fact inline data, which is always aligned on a 2 byte boundary but misaligned for 4 bytes.load
checks for proper alignment and aborts in this case.The solution is to use the
loadUnaligned
call which makes no alignment assumptions.Tests performed
All unit tests keep passing.
Further info for the reviewer
Unfortunately, I have no good isolated reproduction case for the crash, nor can I be more specific about the project in question.
Open Issues