Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sonarQube integrated #48

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: sonarQube integrated #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b603b33
feat: onarQube integrated
anasnadeemws Apr 10, 2024
d550753
fix: updated ci.yml to support sonarqube
anasnadeemws Apr 10, 2024
007b12f
fix: s/pull_rquest/pull_request_target
anasnadeemws Apr 10, 2024
b53b548
feat: pull_request_target added
anasnadeemws Apr 10, 2024
e047428
feat: sonar.yml added
anasnadeemws Apr 10, 2024
e8b83b6
fix: sonar updated
anasnadeemws Apr 10, 2024
d390eea
fix: reverted back sonar.yml to check if auto trigger happens
anasnadeemws Apr 10, 2024
cf9edb1
fix: removed type dependency in ci.yml
anasnadeemws Apr 10, 2024
a9e64c4
fix: sonar reverted back
anasnadeemws Apr 10, 2024
a25334d
fix: s/pull_request/pull_request_target
anasnadeemws Apr 10, 2024
fda0c86
fix: removed double quote
anasnadeemws Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,9 @@ jobs:
token: ${{ secrets.PUSH_TO_PROTECTED_BRANCH }}
branch: ${{ steps.vars.outputs.stage }}
unprotect_reviews: true

- name: SonarQube Scan
uses: sonarsource/sonarqube-scan-action@master
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,9 @@ jobs:
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

- name: SonarQube Scan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to change "pull_request_target" to "pull_request"

uses: sonarsource/sonarqube-scan-action@master
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
6 changes: 3 additions & 3 deletions sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
sonar.organization=wednesday-solutions
sonar.projectKey=wednesday-solutions_react-template
sonar.projectKey=wednesday-solutions_react-graphql-ts-template_AY7GxkO6B2n8RRmGoU1i

sonar.language=js
sonar.language=ts
sonar.sources=.
sonar.tests=app
sonar.exclusions=*./.storybook,*./internals,*./server
sonar.test.inclusions=**/*.test.js
sonar.test.inclusions=**/*.test.ts
sonar.javascript.lcov.reportPaths=./coverage/lcov.info
sonar.testExecutionReportPaths=./reports/test-report.xml
sonar.sourceEncoding=UTF-8
Loading