Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace style-components with emotion #41

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

feat: replace style-components with emotion #41

wants to merge 20 commits into from

Conversation

amartya-ws
Copy link

@amartya-ws amartya-ws commented Feb 22, 2023 •
edited
Loading

Ticket Link

Related Links

Description

  • Replaced styled-components with emotion

  • Fixed tests

  • Fixed docs to add emotion

Steps to Reproduce / Test

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

GIF's

Screenshot 2023-03-15 at 5 21 15 PM

@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited
Loading

Jest Coverage Report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 99.53% 420/422
🟢 Branches 96.55% (-3.45% 🔻) 140/145
🟢 Functions 98.77% (-1.23% 🔻) 160/162
🟢 Lines 99.45% 360/362

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 components/T/index.tsx 100% 75% (-25% 🔻) 100% 100%
🔴 components/Header/index.tsx 88.89% (-11.11% 🔻) 100% 80% (-20% 🔻) 88.89% (-11.11% 🔻)
🟢 containers/HomeContainer/useSort.ts 100% 50% (-50% 🔻) 100% 100%
🟢 containers/HomeContainer/index.tsx 96.88% (-3.13% 🔻) 88.24% (-11.76% 🔻) 88.89% (-11.11% 🔻) 96.67% (-3.33% 🔻)

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 9639ef4

praveenkumar1798
praveenkumar1798 reviewed Mar 13, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@praveenkumar1798
Copy link
Collaborator

Fix the breaking CI @amartya-ws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkumar1798 praveenkumar1798 praveenkumar1798 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amartya-ws @praveenkumar1798