Skip to content

Commit

Permalink
Merge pull request #142 from wednesday-solutions/feat/node-18
Browse files Browse the repository at this point in the history
feat: add support for node-18
  • Loading branch information
alichherawalla authored Jun 28, 2024
2 parents 6f3b5af + 1ed33c6 commit e8119c9
Show file tree
Hide file tree
Showing 38 changed files with 2,728 additions and 1,327 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
node-version: [20.x]
steps:
- uses: actions/checkout@v2
- name: Setup environment
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
node-version: [20.x]
steps:
- uses: wednesday-solutions/[email protected]
with:
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Node Express GraphQL Template CI

on:
pull_request_target:
pull_request:
branches:
- develop
push:
Expand All @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
node-version: [20.x]
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down Expand Up @@ -42,19 +42,21 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}

- uses: sonarsource/sonarqube-quality-gate-action@master
timeout-minutes: 5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- uses: artiomtr/[email protected]

- uses: artiomtr/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
package-manager: yarn
threshold: ${{steps.threshold.outputs.prop}}
skip-step: all
annotations: failed-tests

- uses: codecov/codecov-action@v2
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
8 changes: 6 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
FROM node:14
FROM node:20
ARG ENVIRONMENT_NAME
ARG BUILD_NAME
ENV NODE_OPTIONS=--openssl-legacy-provider

RUN mkdir -p /app-build
ADD . /app-build
WORKDIR /app-build
Expand All @@ -9,9 +11,11 @@ RUN yarn
RUN yarn build:$BUILD_NAME


FROM node:14-alpine
FROM node:20-alpine
ARG ENVIRONMENT_NAME
ARG BUILD_NAME
ENV NODE_OPTIONS=--openssl-legacy-provider

RUN mkdir -p /dist
RUN apk add yarn
RUN yarn global add [email protected]
Expand Down
Loading

1 comment on commit e8119c9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 94.36% 652/691
🟢 Branches 87.7% 214/244
🟢 Functions 94.29% 165/175
🟢 Lines 94.45% 630/667

Test suite run success

177 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from e8119c9

Please sign in to comment.