-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add jest annotation #41
Conversation
WalkthroughThe recent changes bring improvements to Jest coverage integration, React component styling, import organization, and translation management. These updates aim to streamline the project for enhanced maintainability and clarity. Changes
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This comment has been minimized.
This comment has been minimized.
6ad84e0
to
ec27059
Compare
This comment has been minimized.
This comment has been minimized.
Jest Coverage ReportTotal coverage
Show files with reduced coverage 🔻Reduced coverage
Report generated by 🧪jest coverage report action from 483c0d0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
src/common/T/tests/__snapshots__/index.test.tsx.snap
is excluded by!**/*.snap
src/features/repos/components/ErrorState/tests/__snapshots__/index.test.tsx.snap
is excluded by!**/*.snap
src/features/repos/components/RepoList/tests/__snapshots__/index.test.tsx.snap
is excluded by!**/*.snap
Files selected for processing (15)
- .github/workflows/ci.yml (1 hunks)
- jest.config.ts (2 hunks)
- src/common/styled/index.tsx (1 hunks)
- src/containers/Repos/index.tsx (2 hunks)
- src/features/repos/components/ErrorState/index.tsx (2 hunks)
- src/features/repos/components/ErrorState/tests/index.test.tsx (1 hunks)
- src/themes/index.ts (1 hunks)
- src/themes/mui/index.ts (2 hunks)
- src/themes/mui/palette.ts (1 hunks)
- src/translations/en.js (1 hunks)
- src/translations/en.po (4 hunks)
- src/translations/hi.js (1 hunks)
- src/translations/hi.po (4 hunks)
- src/utils/linguiUtils.ts (1 hunks)
- src/utils/testUtils.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (13)
- jest.config.ts
- src/common/styled/index.tsx
- src/containers/Repos/index.tsx
- src/features/repos/components/ErrorState/index.tsx
- src/features/repos/components/ErrorState/tests/index.test.tsx
- src/themes/index.ts
- src/themes/mui/index.ts
- src/themes/mui/palette.ts
- src/translations/en.js
- src/translations/en.po
- src/translations/hi.js
- src/translations/hi.po
- src/utils/linguiUtils.ts
Additional Context Used
GitHub Check Runs (1)
Coverage annotations (🧪 jest-coverage-report-action) success (30)
src/utils/testUtils.tsx: [warning] 16-16: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 30-30: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 47-47: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 55-55: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 47-47: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 47-47: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 56-59: 🧾 Statement is not covered
Warning! Not covered statement
src/utils/testUtils.tsx: [warning] 47-47: 🕹 Function is not covered
Warning! Not covered function
src/utils/testUtils.tsx: [warning] 47-47: 🕹 Function is not covered
Warning! Not covered function
src/utils/testUtils.tsx: [warning] 55-55: 🕹 Function is not covered
Warning! Not covered function
Additional comments not posted (1)
.github/workflows/ci.yml (1)
42-47
: LGTM! Ensure compatibility ofartiomtr/[email protected]
with the project.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: wednesday-solutions_next-bulletproof-ts_AY6yu6eKB2n8RRmGoUz4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/ci.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ci.yml
DO NOT MERGE THIS!
Summary by CodeRabbit
New Features
CustomCard
based on thecolor
prop.Link
from@mui/material
in theRepos
container.Bug Fixes
ErrorState
component under certain conditions.Refactor
CustomPalette
type and related exports.Tests
I18nProvider
directly, enhancing testing reliability.Chores